From b22a1d153080add8ef5604a0698ad933c9f7418e Mon Sep 17 00:00:00 2001 From: Nikola Knezevic Date: Thu, 17 Mar 2022 13:40:53 +0100 Subject: wxwidgets: fix building on darwin Fix building on darwin by passing in all the dependencies and removing compilation switches that do not exist anymore. --- pkgs/development/libraries/wxwidgets/wxGTK31.nix | 39 +++++++++++++++--------- pkgs/top-level/all-packages.nix | 5 ++- 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/pkgs/development/libraries/wxwidgets/wxGTK31.nix b/pkgs/development/libraries/wxwidgets/wxGTK31.nix index c262232f30d08..9deb23ffcf0dd 100644 --- a/pkgs/development/libraries/wxwidgets/wxGTK31.nix +++ b/pkgs/development/libraries/wxwidgets/wxGTK31.nix @@ -17,20 +17,26 @@ , compat28 ? false , compat30 ? true , unicode ? true -, withGtk2 ? true +, withGtk2 ? (!stdenv.isDarwin) , withMesa ? lib.elem stdenv.hostPlatform.system lib.platforms.mesaPlatforms -, withWebKit ? false, webkitgtk -, darwin +, withWebKit ? stdenv.isDarwin +, webkitgtk +, setfile +, AGL +, Carbon +, Cocoa +, Kernel +, QTKit +, AVFoundation +, AVKit +, WebKit }: -assert withMesa -> libGLU != null && libGL != null; -assert withWebKit -> webkitgtk != null; +assert withWebKit -> stdenv.isDarwin; assert withGtk2 -> (!withWebKit); let - inherit (darwin.stubs) setfile; - inherit (darwin.apple_sdk.frameworks) AGL Carbon Cocoa Kernel QTKit; inherit (gnome2) GConf; inherit (gst_all_1) gst-plugins-base gstreamer; gtk = if withGtk2 then gtk2 else gtk3; @@ -57,6 +63,8 @@ stdenv.mkDerivation rec { buildInputs = [ gst-plugins-base gstreamer + ] + ++ lib.optionals (!stdenv.isDarwin) [ gtk libSM libXinerama @@ -68,19 +76,25 @@ stdenv.mkDerivation rec { GConf ] ++ lib.optional withMesa libGLU - ++ lib.optional withWebKit webkitgtk + ++ lib.optional (withWebKit && !stdenv.isDarwin) webkitgtk + ++ lib.optional (withWebKit && stdenv.isDarwin) WebKit ++ lib.optionals stdenv.isDarwin [ + setfile Carbon Cocoa Kernel QTKit - setfile + AVFoundation + AVKit + WebKit ]; propagatedBuildInputs = lib.optional stdenv.isDarwin AGL; configureFlags = [ "--disable-precomp-headers" + # This is the default option, but be explicit + "--disable-monolithic" "--enable-mediactrl" (if compat28 then "--enable-compat28" else "--disable-compat28") (if compat30 then "--enable-compat30" else "--disable-compat30") @@ -88,10 +102,8 @@ stdenv.mkDerivation rec { ++ lib.optional unicode "--enable-unicode" ++ lib.optional withMesa "--with-opengl" ++ lib.optionals stdenv.isDarwin [ - # allow building on 64-bit - "--enable-universal-binaries" - "--with-cocoa" - "--with-macosx-version-min=10.7" + "--with-osx_cocoa" + "--with-libiconv" ] ++ lib.optionals withWebKit [ "--enable-webview" @@ -139,7 +151,6 @@ stdenv.mkDerivation rec { license = licenses.wxWindows; maintainers = with maintainers; [ AndersonTorres tfmoraes ]; platforms = platforms.unix; - badPlatforms = platforms.darwin; # ofBorg is failing, don't know if internal }; passthru = { diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 9edf54d9f32a5..6984682ba778f 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -20727,7 +20727,10 @@ with pkgs; wxmac = callPackage ../development/libraries/wxwidgets/wxmac30.nix { }; - wxGTK31 = callPackage ../development/libraries/wxwidgets/wxGTK31.nix { }; + wxGTK31 = callPackage ../development/libraries/wxwidgets/wxGTK31.nix { + inherit (darwin.stubs) setfile; + inherit (darwin.apple_sdk.frameworks) AGL Carbon Cocoa Kernel QTKit AVFoundation AVKit WebKit; + }; wxGTK31-gtk2 = wxGTK31.override { withGtk2 = true; }; wxGTK31-gtk3 = wxGTK31.override { withGtk2 = false; }; -- cgit 1.4.1