From a78bc76e23284e207cc9e3bc71510e74e6a62c69 Mon Sep 17 00:00:00 2001 From: aszlig Date: Sun, 11 Dec 2022 14:45:30 +0100 Subject: Rename vim_configurable to vim-full The "vim_configurable" derivation has had a long history in nixpkgs back then when there was no RFC process and where people still were figuring out better ways on how to configure compile-time flags. One of those was a composableDerivation function, which was used for "vim_configurable" and mapped attribute sets to autoconf-flags, so that for example if there was a "--enable-foo" flag you could just use something like: vim_configurable.merge { cfg.fooSupport = true; } You'd then get a Vim with "--enable-foo" passed to configureFlags. However, the composableDerivation feature was too complicated and was ultimately removed at some point. While it does allow for things such as introducing new "edf" (stands for Enable Disable Feature and maps the autoconf flags mentioned above to attribute sets) flags, the complexity that comes with that system is way too large than using something like eg.: vim-full.overrideAttrs (drv: { configureFlags = (drv.configureFlags or []) ++ [ "--enable-foo" ]; }) While this looks more verbose than the above, one can easily follow what's happening, whereas if you'd need to add and enable a new "edf" flag, you'd do something like this: vim_configurable.merge { flags = composableDerivation.edf { name = "foo"; }; cfg.fooSupport = true; } I admit that this does look a little nicer, but even I'm not sure whether it's worth adding so much complexity since in practice I rarely came across a sitation where something like the above would be really beneficial. So back then when "vim_configurable" was introduced[1], it was used as an alternative to the main vim derivation but using composableDerivation instead. Nowadays however, vim_configurable no longer uses composableDerivation and the rename also doesn't change any features, so I think it's safe to rename vim_configurable to vim-full in Vuizvui. [1]: https://github.com/NixOS/nixpkgs/commit/9a4e9e7a3b4014bb3c9f678ec22d254b85c4c98a [2]: https://github.com/NixOS/nixpkgs/commit/4e5ebcc3ed1de9c5c2001c7d5829f4566e0bde3f Signed-off-by: aszlig Cc: @Profpatsch Cc: @devhell --- machines/profpatsch/pkgs.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'machines') diff --git a/machines/profpatsch/pkgs.nix b/machines/profpatsch/pkgs.nix index 02a4b9df..330ed1c2 100644 --- a/machines/profpatsch/pkgs.nix +++ b/machines/profpatsch/pkgs.nix @@ -14,7 +14,7 @@ let beets = pkgs.beets.override { enableAlternatives = true; }; - vim = pkgs.vim_configurable; + vim = pkgs.vim-full; fast-init = pkgs.haskellPackages.callPackage (import "${(pkgs.fetchFromGitHub { owner = "Profpatsch"; -- cgit 1.4.1