celluloid: refactor

- finalAttrs
- strictDeps
- meta.changelog and meta.mainProgram

2 files changed, 11 insertions, 9 deletions

diff --git a/pkgs/applications/video/celluloid/default.nix b/pkgs/by-name/ce/celluloid/package.nix
index 9c7c49f726b56..c0ada66edc605 100644
--- a/pkgs/applications/video/celluloid/default.nix
+++ b/pkgs/by-name/ce/celluloid/package.nix
@@ -16,14 +16,14 @@
 , wrapGAppsHook4
 }:
 
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "celluloid";
   version = "0.26";
 
   src = fetchFromGitHub {
     owner = "celluloid-player";
     repo = "celluloid";
-    rev = "v${version}";
+    rev = "v${finalAttrs.version}";
     hash = "sha256-npaagLlkwDe0r0hqj7buM4B9sbLCX1sR2yFXXj+obdE=";
   };
 
@@ -49,11 +49,13 @@ stdenv.mkDerivation rec {
     patchShebangs meson-post-install.py src/generate-authors.py
   '';
 
+  strictDeps = true;
+
   doCheck = true;
 
   passthru.updateScript = nix-update-script { };
 
-  meta = with lib; {
+  meta = {
     homepage = "https://github.com/celluloid-player/celluloid";
     description = "Simple GTK frontend for the mpv video player";
     longDescription = ''
@@ -61,8 +63,10 @@ stdenv.mkDerivation rec {
       Celluloid interacts with mpv via the client API exported by libmpv,
       allowing access to mpv's powerful playback capabilities.
     '';
-    license = licenses.gpl3Plus;
-    maintainers = with maintainers; [ AndersonTorres ];
-    platforms = platforms.linux;
+    changelog = "https://github.com/celluloid-player/celluloid/releases/tag/${finalAttrs.src.rev}";
+    license = lib.licenses.gpl3Plus;
+    mainProgram = "celluloid";
+    maintainers = with lib.maintainers; [ AndersonTorres ];
+    platforms = lib.platforms.linux;
   };
-}
+})
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index cdd8a4aef23a3..59c64ec0cdbef 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -32488,8 +32488,6 @@ with pkgs;
 
   gnomecast = callPackage ../applications/video/gnomecast { };
 
-  celluloid = callPackage ../applications/video/celluloid { };
-
   gnome-recipes = callPackage ../applications/misc/gnome-recipes {
     inherit (gnome) gnome-autoar;
   };