diff options
| author | aszlig <aszlig@redmoonstudios.org> | 2017-06-23 05:33:06 +0200 |
|---|---|---|
| committer | aszlig <aszlig@redmoonstudios.org> | 2017-06-23 05:33:06 +0200 |
| commit | fa6fd34fcca07c0762ef3bc44962e2dc49937454 (patch) | |
| tree | d2e63002c27238d04526ecaf3e5962e4ebce2f5c | |
| parent | 6fb9f892382b4b091fc9edcae00e2eb4c0729bda (diff) | |
github/pr-template: Add note about NixOS tests
On several occasions I've seen people bumping packages which have NixOS tests but without actually running them. While this probably won't prevent such occasions entirely, at least it serves as an additional checklist item so contributors don't forget about these tests. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3482ae16e2639..4b9345b087ee3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,6 +11,7 @@ - [ ] NixOS - [ ] macOS - [ ] Linux +- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). |