diff options
| author | Guillaume Girol <symphorien+git@xlumurb.eu> | 2022-02-11 12:00:00 +0000 |
|---|---|---|
| committer | Guillaume Girol <symphorien+git@xlumurb.eu> | 2022-02-12 12:00:00 +0000 |
| commit | 02a8d5984cf597032e4797d2fc19355026427c7d (patch) | |
| tree | d1fc0e77b3cf9863bc1f6bd359299a90ce1c3fde /doc/contributing | |
| parent | 48d63e924a2666baf37f4f14a18f19347fbd54a2 (diff) | |
doc: discourage setting `phases`, document/encourage runHook instead.
Source: https://matrix.to/#/!kjdutkOsheZdjqYmqp:nixos.org/$mff3KCoPY5sfgsUhKn0e4va7hnz7KMXARaO2_UaLNM4?via=nixos.org&via=matrix.org&via=nixos.dev
Diffstat (limited to 'doc/contributing')
| -rw-r--r-- | doc/contributing/reviewing-contributions.chapter.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/doc/contributing/reviewing-contributions.chapter.md b/doc/contributing/reviewing-contributions.chapter.md index 3f3ba60947ccd..0a90781d0c59e 100644 --- a/doc/contributing/reviewing-contributions.chapter.md +++ b/doc/contributing/reviewing-contributions.chapter.md @@ -103,7 +103,8 @@ Sample template for a new package review is provided below. - [ ] `meta.maintainers` is set - [ ] build time only dependencies are declared in `nativeBuildInputs` - [ ] source is fetched using the appropriate function -- [ ] phases are respected +- [ ] the list of `phases` is not overridden +- [ ] when a phase (like `installPhase`) is overridden it starts with `runHook preInstall` and ends with `runHook postInstall`. - [ ] patches that are remotely available are fetched with `fetchpatch` ##### Possible improvements |