diff options
author | éclairevoyant <848000+eclairevoyant@users.noreply.github.com> | 2023-10-09 09:01:53 -0400 |
---|---|---|
committer | éclairevoyant <848000+eclairevoyant@users.noreply.github.com> | 2023-10-09 09:01:53 -0400 |
commit | 116ab287c59d9861ecc1404488bff0219cba6d69 (patch) | |
tree | 8348c7116a34a5d7330b4c48b050ba1f266af344 /maintainers/scripts | |
parent | d88d7ed8462db3613c1c89a19525076d2a4242fd (diff) |
maintainers/fix-maintainers.pl: handle null github handles
* use attrname in log messages instead of github handle * don't remove users simply for empty github handles, if their user still exists (prevents #259555)
Diffstat (limited to 'maintainers/scripts')
-rwxr-xr-x | maintainers/scripts/fix-maintainers.pl | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/maintainers/scripts/fix-maintainers.pl b/maintainers/scripts/fix-maintainers.pl index a83df9ec0cf0f..6432f0ca83e14 100755 --- a/maintainers/scripts/fix-maintainers.pl +++ b/maintainers/scripts/fix-maintainers.pl @@ -18,7 +18,6 @@ while(my($k, $v) = each %$maintainers_json) { my $current_user = %$v{'github'}; if (!defined $current_user) { print "$k has no github handle\n"; - next; } my $github_id = %$v{'githubId'}; if (!defined $github_id) { @@ -37,13 +36,16 @@ while(my($k, $v) = each %$maintainers_json) { sleep($ratelimit_reset - time() + 5); } if ($resp->code != 200) { - print $current_user . " likely deleted their github account\n"; + print "$k likely deleted their github account\n"; next; } my $resp_json = from_json($resp->content); my $api_user = %$resp_json{"login"}; - if (lc($current_user) ne lc($api_user)) { - print $current_user . " is now known on github as " . $api_user . ". Editing maintainer-list.nix…\n"; + if (!defined $current_user) { + print "$k is known on github as $api_user.\n"; + } + elsif (lc($current_user) ne lc($api_user)) { + print "$k is now known on github as $api_user. Editing maintainer-list.nix…\n"; my $file = path($maintainers_list_nix); my $data = $file->slurp_utf8; $data =~ s/github = "$current_user";$/github = "$api_user";/m; |