about summary refs log tree commit diff
path: root/pkgs/applications/audio/ympd
diff options
context:
space:
mode:
authorSergei Trofimovich <slyich@gmail.com>2022-05-18 08:01:16 +0100
committerSergei Trofimovich <slyich@gmail.com>2022-05-18 08:05:39 +0100
commit4e4ffb73e83b10212df42562db00108f8c195e0f (patch)
treea628c3ce005743d08254ece051cd7c0de9c5f11c /pkgs/applications/audio/ympd
parent115f2f7878bbee1683071f1ef3c031736fed822d (diff)
ympd: add -fcommon workaround
Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

    ld: CMakeFiles/ympd.dir/src/mpd_client.c.o:(.bss+0x0): multiple definition of `mpd';
      CMakeFiles/ympd.dir/src/ympd.c.o:(.bss+0x20): first defined here
Diffstat (limited to 'pkgs/applications/audio/ympd')
-rw-r--r--pkgs/applications/audio/ympd/default.nix9
1 files changed, 8 insertions, 1 deletions
diff --git a/pkgs/applications/audio/ympd/default.nix b/pkgs/applications/audio/ympd/default.nix
index 38c05276be4b7..218204d690a16 100644
--- a/pkgs/applications/audio/ympd/default.nix
+++ b/pkgs/applications/audio/ympd/default.nix
@@ -18,11 +18,18 @@ stdenv.mkDerivation rec {
     sha256 = "1nvb19jd556v2h2bi7w4dcl507p3p8xvjkqfzrcsy7ccy3502brq";
   };
 
+  # Workaround build failure on -fno-common toolchains like upstream
+  # gcc-10. Otherwise build fails as:
+  #   ld: CMakeFiles/ympd.dir/src/mpd_client.c.o:(.bss+0x0): multiple definition of `mpd';
+  #     CMakeFiles/ympd.dir/src/ympd.c.o:(.bss+0x20): first defined here
+  # Should be fixed by pending https://github.com/notandy/ympd/pull/191 (does not apply as is).
+  NIX_CFLAGS_COMPILE = "-fcommon";
+
   nativeBuildInputs = [ cmake pkg-config ];
   buildInputs = [ libmpdclient openssl ];
 
   meta = with lib; {
-    homepage = "https://www.ympd.org";
+    homepage = "https://github.com/notandy/ympd";
     description = "Standalone MPD Web GUI written in C, utilizing Websockets and Bootstrap/JS";
     maintainers = [ maintainers.siddharthist ];
     platforms = platforms.unix;