about summary refs log tree commit diff
path: root/pkgs/applications/backup/deja-dup
diff options
context:
space:
mode:
authorJan Tojnar <jtojnar@gmail.com>2018-02-23 01:42:35 +0100
committerJan Tojnar <jtojnar@gmail.com>2018-03-22 07:30:58 +0100
commitde910a040b64a2e0c808a89e62717bb80c9f0043 (patch)
treefee80798626752055475594bdc2aa25bb79928e8 /pkgs/applications/backup/deja-dup
parent33e6ef179028ab9881d6feb465848c7ecc5c61a8 (diff)
meson: fix rpath fixup
In common distributions, RPATH is only needed for internal libraries so
meson removes everything else. With Nix, the locations of libraries
are not as predictable, therefore we need to keep them in the RPATH. [1]

Previously we have just kept the RPATH produced by the linker, patching
meson not to remove it. This deprived us of potentially replacing it
with install_rpath provided by project so we had to re-add it manually,
and also introduced a vulnerability of keeping build paths in RPATH.

This commit restores the clean-up but modifies it so the items starting
with /nix/store are retained.

This should be relatively safe since the store is immutable, however,
there might be some unwanted retainment of build_rpath [2] if it contains
paths from Nix store.

[1]: https://github.com/NixOS/nixpkgs/issues/31222#issuecomment-365811634
[2]: http://mesonbuild.com/Release-notes-for-0-42-0.html#added-build_rpath-keyword-argument
Diffstat (limited to 'pkgs/applications/backup/deja-dup')
0 files changed, 0 insertions, 0 deletions