about summary refs log tree commit diff
path: root/pkgs/applications/editors/emacs/elisp-packages
diff options
context:
space:
mode:
authorLin Jian <me@linj.tech>2024-02-26 00:35:04 +0800
committerLin Jian <me@linj.tech>2024-03-03 01:03:25 +0800
commit7374ffe8f734d5bc288dfb960c8df57c1a4f53d4 (patch)
tree5e01099c9b404964a917c82f93e6f973c0b47b62 /pkgs/applications/editors/emacs/elisp-packages
parent41e7732291b75b59f4a74721c24ac0fe5c31a24d (diff)
emacs.pkgs.seq: stop shadowing it
magit requires[1] seq 2.24.  seq from GNU Elpa satisfies that.
However, it is shadowed by the Emacs builtin one to workaround an old
bug[2] and the version of the builtin seq in Emacs 28 is only 2.23.
So magit is broken for Emacs 28 which is the default one in NixOS
23.11 and available in the unstable branch.

This patch fixes magit by stopping shadowing seq from GNU Elpa since
that old bug[2] is not relevant now.

Fixes https://github.com/NixOS/nixpkgs/issues/272019.

[1]: https://github.com/magit/magit/blob/f4ff817cb2a48f0f7887050c3be469c03a059567/lisp/magit.el#L27
[2]: https://github.com/NixOS/nixpkgs/pull/74936
Diffstat (limited to 'pkgs/applications/editors/emacs/elisp-packages')
-rw-r--r--pkgs/applications/editors/emacs/elisp-packages/elpa-packages.nix3
1 files changed, 0 insertions, 3 deletions
diff --git a/pkgs/applications/editors/emacs/elisp-packages/elpa-packages.nix b/pkgs/applications/editors/emacs/elisp-packages/elpa-packages.nix
index 0b142281559a9..4849f90edecd9 100644
--- a/pkgs/applications/editors/emacs/elisp-packages/elpa-packages.nix
+++ b/pkgs/applications/editors/emacs/elisp-packages/elpa-packages.nix
@@ -63,9 +63,6 @@ self: let
       cl-print = null; # builtin
       tle = null; # builtin
       advice = null; # builtin
-      seq = if lib.versionAtLeast self.emacs.version "27"
-            then null
-            else super.seq;
       # Compilation instructions for the Ada executables:
       # https://www.nongnu.org/ada-mode/
       ada-mode = super.ada-mode.overrideAttrs (old: {