about summary refs log tree commit diff
path: root/pkgs/applications/virtualization/singularity/generic.nix
diff options
context:
space:
mode:
authorYueh-Shun Li <44064051+ShamrockLee@users.noreply.github.com>2023-02-14 17:22:39 +0800
committerYueh-Shun Li <44064051+ShamrockLee@users.noreply.github.com>2023-02-19 07:55:10 +0000
commit6e9902c7f6ef9af4434f01db2c05a6a3f488ce97 (patch)
tree99734485eb07c8a194a5fa11a4c271d8dad6ecd4 /pkgs/applications/virtualization/singularity/generic.nix
parent8ee6a032ca2f30d24e481e15d509cfd1da0e7119 (diff)
apptainer: always specify either --with-suid or --without-suid build flag
Diffstat (limited to 'pkgs/applications/virtualization/singularity/generic.nix')
-rw-r--r--pkgs/applications/virtualization/singularity/generic.nix6
1 files changed, 4 insertions, 2 deletions
diff --git a/pkgs/applications/virtualization/singularity/generic.nix b/pkgs/applications/virtualization/singularity/generic.nix
index 562781b09a315..f20735e45e3dc 100644
--- a/pkgs/applications/virtualization/singularity/generic.nix
+++ b/pkgs/applications/virtualization/singularity/generic.nix
@@ -52,6 +52,9 @@ in
   # SingularityCE 3.10.0 and above requires explicit --without-seccomp when libseccomp is not available.
 , enableSeccomp ? true
   # Whether the configure script treat SUID support as default
+  # When equal to enableSuid, it supress the --with-suid / --without-suid build flag
+  # It can be set to `null` to always pass either --with-suid or --without-suided
+  # Type: null or boolean
 , defaultToSuid ? true
   # Whether to compile with SUID support
 , enableSuid ? false
@@ -131,8 +134,7 @@ buildGoModule {
     "--runstatedir=/var/run"
   ]
   ++ lib.optional (!enableSeccomp) "--without-seccomp"
-  ++ lib.optional (defaultToSuid && !enableSuid) "--without-suid"
-  ++ lib.optional (!defaultToSuid && enableSuid) "--with-suid"
+  ++ lib.optional (enableSuid != defaultToSuid) (if enableSuid then "--with-suid" else "--without-suid")
   ++ extraConfigureFlags
   ;