diff options
author | Alyssa Ross <hi@alyssa.is> | 2023-05-25 10:56:43 +0000 |
---|---|---|
committer | Alyssa Ross <hi@alyssa.is> | 2023-05-27 13:21:15 +0000 |
commit | f333927497274800b76f5c016a89bc51b33893f5 (patch) | |
tree | ab6d10676cffcfde76e656fcb8e7800180712ca2 /pkgs/applications/window-managers/weston/default.nix | |
parent | ef39dca2f2b8eb9e4c1825ae5bcbd0de7748ff8c (diff) |
weston: remove unused dependencies
colord support is deprecated and disabled by default. libGL is redundant with Mesa. libXcursor is only required when Xwayland is enabled. libunwind and mtdev is unused since Weston 4. libxcb and udev are propagated. pam is unused since Weston 11. There's no "vaapi" package at all, and there never has been. This presumably meant to refer to libva. This is a very good demonstration of the problem with the "? null" pattern for optional dependencies! As a result, VA-API support had been unintentionally disabled by default this whole time.
Diffstat (limited to 'pkgs/applications/window-managers/weston/default.nix')
-rw-r--r-- | pkgs/applications/window-managers/weston/default.nix | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/pkgs/applications/window-managers/weston/default.nix b/pkgs/applications/window-managers/weston/default.nix index 13dd27e93865c..84ef3b8d33808 100644 --- a/pkgs/applications/window-managers/weston/default.nix +++ b/pkgs/applications/window-managers/weston/default.nix @@ -1,10 +1,9 @@ { lib, stdenv, fetchurl , meson, ninja, pkg-config, python3, wayland-scanner -, cairo, colord, dbus, lcms2, libGL, libXcursor, libdrm, libevdev, libinput -, libjpeg, seatd, libxcb, libxkbcommon, mesa, mtdev, pam, udev, wayland -, wayland-protocols -, pipewire ? null, pango ? null, libunwind ? null, freerdp ? null, vaapi ? null -, libva ? null, libwebp ? null, xwayland ? null +, cairo, dbus, lcms2, libdrm, libevdev, libinput, libjpeg, seatd, libxkbcommon +, mesa, wayland, wayland-protocols +, pipewire ? null, pango ? null, freerdp ? null +, libXcursor ? null, libva ? null, libwebp ? null, xwayland ? null # beware of null defaults, as the parameters *are* supplied by callPackage by default , buildDemo ? true , buildRemoting ? true, gst_all_1 @@ -22,16 +21,15 @@ stdenv.mkDerivation rec { depsBuildBuild = [ pkg-config ]; nativeBuildInputs = [ meson ninja pkg-config python3 wayland-scanner ]; buildInputs = [ - cairo colord dbus freerdp lcms2 libGL libXcursor libdrm libevdev libinput - libjpeg seatd libunwind libva libwebp libxcb libxkbcommon mesa mtdev pam - pango pipewire udev vaapi wayland wayland-protocols + cairo dbus freerdp lcms2 libXcursor libdrm libevdev libinput libjpeg seatd + libva libwebp libxkbcommon mesa pango pipewire wayland wayland-protocols ] ++ lib.optionals buildRemoting [ gst_all_1.gstreamer gst_all_1.gst-plugins-base ]; mesonFlags= [ - "-Dbackend-drm-screencast-vaapi=${lib.boolToString (vaapi != null)}" + "-Dbackend-drm-screencast-vaapi=${lib.boolToString (libva != null)}" "-Dbackend-rdp=${lib.boolToString (freerdp != null)}" "-Dxwayland=${lib.boolToString (xwayland != null)}" # Default is true! (lib.mesonBool "remoting" buildRemoting) |