diff options
author | Vladimír Čunát <v@cunat.cz> | 2020-08-16 10:14:21 +0200 |
---|---|---|
committer | Vladimír Čunát <v@cunat.cz> | 2020-08-16 10:23:53 +0200 |
commit | 3937923f81b08de1e7f8593ca62d05b8337daaaf (patch) | |
tree | 5b8affb7e05ec16983e9e98478bdc7b2706173df /pkgs/build-support | |
parent | 3ab2bf69ce4394f99f5c512d95c26e6d44618786 (diff) |
nixos/systemd.tmpfiles.packages: fix an edge case
symlinkJoin can break (silently) when the passed paths contain symlinks to directories. This should work now. Down-side: when lib/tmpfiles.d doesn't exist for some passed package, the error message is a little less explicit, because we never get to the postBuild phase (and symlinkJoin doesn't provide a better way): /nix/store/HASH-NAME/lib/tmpfiles.d: No such file or directory Also, it seemed pointless to create symlinks for whole package trees and using only a part of the result (usually very small part).
Diffstat (limited to 'pkgs/build-support')
-rw-r--r-- | pkgs/build-support/trivial-builders.nix | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/pkgs/build-support/trivial-builders.nix b/pkgs/build-support/trivial-builders.nix index 3c81a4ece657e..eab5366e1839e 100644 --- a/pkgs/build-support/trivial-builders.nix +++ b/pkgs/build-support/trivial-builders.nix @@ -240,6 +240,8 @@ rec { * This creates a single derivation that replicates the directory structure * of all the input paths. * + * BEWARE: it may not "work right" when the passed paths contain symlinks to directories. + * * Examples: * # adds symlinks of hello to current build. * symlinkJoin { name = "myhello"; paths = [ pkgs.hello ]; } |