about summary refs log tree commit diff
path: root/pkgs/by-name/jd/jdt-language-server
diff options
context:
space:
mode:
authorArtturin <Artturin@artturin.com>2024-09-24 18:50:49 +0300
committerArtturin <Artturin@artturin.com>2024-09-25 00:04:37 +0300
commite0464e47880a69896f0fb1810f00e0de469f770a (patch)
tree7890601c5347b66e5c74671b9dbbcddf1b30d1c3 /pkgs/by-name/jd/jdt-language-server
parentaaa7fb5840f278da8010fe7466c3d952f7e536da (diff)
treewide: replace `stdenv.is` with `stdenv.hostPlatform.is`
In preparation for the deprecation of `stdenv.isX`.

These shorthands are not conducive to cross-compilation because they
hide the platforms.

Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way

One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059

There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.

```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
Diffstat (limited to 'pkgs/by-name/jd/jdt-language-server')
-rw-r--r--pkgs/by-name/jd/jdt-language-server/package.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/pkgs/by-name/jd/jdt-language-server/package.nix b/pkgs/by-name/jd/jdt-language-server/package.nix
index 33d735424c320..268599a385ec1 100644
--- a/pkgs/by-name/jd/jdt-language-server/package.nix
+++ b/pkgs/by-name/jd/jdt-language-server/package.nix
@@ -38,7 +38,7 @@ stdenv.mkDerivation (finalAttrs: {
       # The application ships with different config directories for each platform.
       # Note the application come with ARM variants as well, although the
       # current included wrapper doesn't use them.
-      configDir = if stdenv.isDarwin then "config_mac" else "config_linux";
+      configDir = if stdenv.hostPlatform.isDarwin then "config_mac" else "config_linux";
     in
     ''
       runHook preInstall