diff options
author | Gabriel Gonzalez <Gabriel439@gmail.com> | 2020-11-01 12:26:33 -0800 |
---|---|---|
committer | Emery Hemingway <ehmry@posteo.net> | 2020-11-11 11:16:04 +0100 |
commit | 87d5e6fc1adc56c3fb2b731e4183c6fd0c6a75a8 (patch) | |
tree | dd7074645309e001e4352daffac674e843c516f4 /pkgs/development/interpreters/dhall | |
parent | f9dd8f04a02568b202df0c37fc34b95fec0721c6 (diff) |
Change idiom for overriding Dhall package version
Before this change, a Dhall package like the Prelude would be encoded as a record with one field per supported version. Then downstream packages would specify which package to override by selecting a different record field. The problem with that approach is that it did not provide an easy way to override a package to a version other than the default ones supplied by Nixpkgs. Normally you would use the `.override` method for this purpose, but the `override` method added by `buildDhall{Directory,GitHub}Package` is clobbered by the `override` method added by `callPackage` in `./pkgs/top-level/dhall-packages.nix`. The solution is to add a separate `.overridePackage` method which is essentially the exact same as `.override`, except that it is no longer clobbered by `callPackage`. This `.overridePackage` method allows one to override the arguments supplied to `buildDhall{Directory,GitHub}Package`, making it easier to specify package versions outside of the ones supported by Nixpkgs.. This also includes a change to only build one (preferred) version of each package (instead of multiple supported versions per package), in order to minimize the maintenance burden for the Dhall package set.
Diffstat (limited to 'pkgs/development/interpreters/dhall')
-rw-r--r-- | pkgs/development/interpreters/dhall/build-dhall-directory-package.nix | 2 | ||||
-rw-r--r-- | pkgs/development/interpreters/dhall/build-dhall-github-package.nix | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/pkgs/development/interpreters/dhall/build-dhall-directory-package.nix b/pkgs/development/interpreters/dhall/build-dhall-directory-package.nix index b4401a85d141a..0c182b25d573a 100644 --- a/pkgs/development/interpreters/dhall/build-dhall-directory-package.nix +++ b/pkgs/development/interpreters/dhall/build-dhall-directory-package.nix @@ -5,7 +5,7 @@ # the `file` # # This function is used by `dhall-to-nixpkgs` when given a directory -lib.makeOverridable +lib.makePackageOverridable ( { # Arguments passed through to `buildDhallPackage` name , dependencies ? [] diff --git a/pkgs/development/interpreters/dhall/build-dhall-github-package.nix b/pkgs/development/interpreters/dhall/build-dhall-github-package.nix index 9289e9b656d30..bdb958fb8bd7e 100644 --- a/pkgs/development/interpreters/dhall/build-dhall-github-package.nix +++ b/pkgs/development/interpreters/dhall/build-dhall-github-package.nix @@ -1,7 +1,7 @@ { buildDhallPackage, fetchFromGitHub, lib }: # This function is used by `dhall-to-nixpkgs` when given a GitHub repository -lib.makeOverridable +lib.makePackageOverridable ( { # Arguments passed through to `buildDhallPackage` name , dependencies ? [] |