diff options
author | Sergei Trofimovich <slyich@gmail.com> | 2022-11-02 07:53:30 +0000 |
---|---|---|
committer | Sergei Trofimovich <slyich@gmail.com> | 2022-11-02 07:54:29 +0000 |
commit | 627b4dc438fdf3a6248cf5c833c153b942a8c469 (patch) | |
tree | e06848368f1802e3343dcc307ba82872accb1fd6 /pkgs/development/libraries/aws-sdk-cpp | |
parent | 5a70f6da9229e4ddee90d7629769b47e34c6417b (diff) |
aws-sdk-cpp: disable blanket -Werror
`-Werror` flag usually causes build failures due to minor changes in compiler versions. They might be useful for developers themselves but are rarely useful for distributions. For example right now `aws-sdk-cpp` fails to compile on `gcc-13` due to a `gcc` infelicity: https://gcc.gnu.org/PR107488 While this concrete instance is a compiler bug generally `-Werror` makes users' lives harder. Specific `-Werror=<foo>` are better way to prevent certain classes of bugs. The change removes blanket `-Werror` with a `substituteInPlace` call.
Diffstat (limited to 'pkgs/development/libraries/aws-sdk-cpp')
-rw-r--r-- | pkgs/development/libraries/aws-sdk-cpp/default.nix | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/pkgs/development/libraries/aws-sdk-cpp/default.nix b/pkgs/development/libraries/aws-sdk-cpp/default.nix index 5d5c5e9560261..efe8129d3b4f6 100644 --- a/pkgs/development/libraries/aws-sdk-cpp/default.nix +++ b/pkgs/development/libraries/aws-sdk-cpp/default.nix @@ -45,6 +45,11 @@ stdenv.mkDerivation rec { ]; postPatch = '' + # Avoid blanket -Werror to evade build failures on less + # tested compilers. + substituteInPlace cmake/compiler_settings.cmake \ + --replace '"-Werror"' ' ' + # Missing includes for GCC11 sed '5i#include <thread>' -i \ aws-cpp-sdk-cloudfront-integration-tests/CloudfrontOperationTest.cpp \ |