summary refs log tree commit diff
path: root/pkgs/development
diff options
context:
space:
mode:
authoroutfoxxed <outfoxxed@outfoxxed.me>2023-11-09 08:39:30 -0800
committerGitHub <noreply@github.com>2023-11-09 16:39:30 +0000
commit9b1c922663084191d31802b8b19b20b37eb2b26a (patch)
tree5e9c39d48b30b06325a428b596ff9e44bcf14bcd /pkgs/development
parenta1e93cb97d4ea97a57100c1683964b10e53e0fc8 (diff)
fix: only substitute ERTS for escript builds in rebar3Relx (#266215)
* fix: only substitute ERTS for escript builds in rebar3Relx

Previously beamPackages.rebar3Relx substituted references to erlang
for all builds, which only works for escript builds.

Fixes #261354

* doc: add comment mentioning fixed issue
Diffstat (limited to 'pkgs/development')
-rw-r--r--pkgs/development/beam-modules/rebar3-release.nix3
1 files changed, 2 insertions, 1 deletions
diff --git a/pkgs/development/beam-modules/rebar3-release.nix b/pkgs/development/beam-modules/rebar3-release.nix
index b884809505f33..621887d6cd124 100644
--- a/pkgs/development/beam-modules/rebar3-release.nix
+++ b/pkgs/development/beam-modules/rebar3-release.nix
@@ -84,7 +84,8 @@ let
         runHook postInstall
       '';
 
-      postInstall = ''
+      # Release will generate a binary which will cause a read null byte failure, see #261354
+      postInstall = lib.optionalString (releaseType == "escript") ''
         for dir in $out/rel/*/erts-*; do
           echo "ERTS found in $dir - removing references to erlang to reduce closure size"
           for f in $dir/bin/{erl,start}; do