about summary refs log tree commit diff
path: root/pkgs/tools/misc/diffoscope
diff options
context:
space:
mode:
authorSergei Trofimovich <slyich@gmail.com>2022-07-27 22:19:21 +0100
committerSergei Trofimovich <slyich@gmail.com>2022-07-27 22:19:21 +0100
commit0fdceb52c78eacd4f3235a67929dd1378655c158 (patch)
tree77a702e9991c9f17d81a53b8725652e6792f2fb1 /pkgs/tools/misc/diffoscope
parent3ddbf2094eb672dba1da917310c2f72863c05ec5 (diff)
diffoscope: use multitarget binutils
multitarget binutils is useful for diffing for directories with binaries
foreign to system where diffoscope runs.

before the change:

    $ nix run nixpkgs#diffoscope /tmp/a-Mcrt1.o /tmp/b-Mcrt1.o
    2022-07-27 21:20:35 E: diffoscope.comparators.elf: Command '['objdump --line-numbers --disassemble --demangle --reloc --no-show-raw-insn --section=.text {}']' returned non-zero exit status 1.
    2022-07-27 21:20:35 E: diffoscope.comparators.elf: Command '['objdump --disassemble --demangle --no-show-raw-insn --section=.text {}']' returned non-zero exit status 1.
    --- /tmp/a-Mcrt1.o
    +++ /tmp/b-Mcrt1.o
    ├── readelf --wide --decompress --string-dump=.debug_str {}
    ...

After the change:

    ./result/bin/diffoscope /tmp/a-Mcrt1.o /tmp/b-Mcrt1.o
    --- /tmp/a-Mcrt1.o
    +++ /tmp/b-Mcrt1.o
    ├── readelf --wide --decompress --string-dump=.debug_str {}
    ...
Diffstat (limited to 'pkgs/tools/misc/diffoscope')
-rw-r--r--pkgs/tools/misc/diffoscope/default.nix4
1 files changed, 2 insertions, 2 deletions
diff --git a/pkgs/tools/misc/diffoscope/default.nix b/pkgs/tools/misc/diffoscope/default.nix
index d12b6ecf6606c..72a72b34373cf 100644
--- a/pkgs/tools/misc/diffoscope/default.nix
+++ b/pkgs/tools/misc/diffoscope/default.nix
@@ -1,5 +1,5 @@
 { lib, stdenv, fetchurl, python3Packages, docutils, help2man, installShellFiles
-, abootimg, acl, apksigner, apktool, binutils-unwrapped, bzip2, cbfstool, cdrkit, colord, colordiff, coreutils, cpio, db, diffutils, dtc
+, abootimg, acl, apksigner, apktool, binutils-unwrapped-all-targets, bzip2, cbfstool, cdrkit, colord, colordiff, coreutils, cpio, db, diffutils, dtc
 , e2fsprogs, enjarify, file, findutils, fontforge-fonttools, ffmpeg, fpc, gettext, ghc, ghostscriptX, giflib, gnumeric, gnupg, gnutar
 , gzip, hdf5, imagemagick, jdk, libarchive, libcaca, llvm, lz4, mono, ocaml, oggvideotools, openssh, openssl, pdftk, pgpdump, poppler_utils, procyon, qemu, R
 , radare2, sng, sqlite, squashfsTools, tcpdump, ubootTools, odt2txt, unzip, wabt, xmlbeans, xxd, xz, zip, zstd
@@ -44,7 +44,7 @@ python3Packages.buildPythonApplication rec {
   #
   # Still missing these tools: docx2txt lipo otool r2pipe
   pythonPath = [
-      binutils-unwrapped bzip2 colordiff coreutils cpio db diffutils
+      binutils-unwrapped-all-targets bzip2 colordiff coreutils cpio db diffutils
       e2fsprogs file findutils fontforge-fonttools gettext gnutar gzip
       libarchive lz4 openssl pgpdump sng sqlite squashfsTools unzip xxd
       xz zip zstd