about summary refs log tree commit diff
path: root/.github/PULL_REQUEST_TEMPLATE.md
AgeCommit message (Collapse)AuthorFilesLines
2020-11-13PULL_REQUEST_TEMPLATE.md: use rendered docsJonathan Ringer1-1/+1
2020-05-03treewide: use https for nixos.org and hydra.nixos.orgPavol Rusnak1-1/+1
tarballs.nixos.org is omitted from the change because urls from there are always hashed and checked
2020-04-27PULL_REQUEST_TEMPLATE: try to simplify call-for-reviewJörg Thalheim1-1/+10
The text is quite long and hard to read in hub (because it is one whole line with no line breaks). Also simplified the language/sentence structure a bit for non-native speakers.
2020-01-03.github: remove cc from pull-request templateIngolf Wagner1-4/+0
2019-12-22nixpkgs-review: 2.1.0 -> 2.1.1Jörg Thalheim1-1/+1
changelog: https://github.com/Mic92/nixpkgs-review/releases/tag/2.1.1
2019-10-30.github: clarify things done re: sandboxingAmerico1-1/+1
Per https://github.com/NixOS/nixpkgs/pull/58147#issuecomment-478234495 sandboxing is not fully functional on macOS. .github: specify where sandboxing can be run Co-Authored-By: Jon <jonringer@users.noreply.github.com> .github: remove macOS note
2019-10-28Fix link in PULL_REQUEST_TEMPLATE.md (the same link)Vladimír Čunát1-1/+1
2019-07-30PULL_REQUEST_TEMPLATE: Add "Notify maintainers" sectionSteven Shaw1-1/+3
2019-07-01PULL_REQUEST_TEMPLATE: "Assured whether" -> "Ensured that"Craig Hall1-1/+1
2019-04-04Merge pull request #58098 from Infinisil/encouraging_reviewsworldofpeace1-0/+1
PULL_REQUEST_TEMPLATE: Add encouragement to review PRs
2019-03-28PULL_REQUEST_TEMPLATE: Add encouragement to review PRsSilvan Mosberger1-1/+1
2019-03-20doc/reviewing-contributions: nix-review instead of nox-reviewJörg Thalheim1-2/+1
It is faster, handles more edge cases and allows to test/review the built packages interactively.
2018-11-22PULL_REQUEST_TEMPLATE: Ask for docsNiklas Hambüchen1-0/+1
2018-06-21PULL_REQUEST_TEMPLATE.md: Ask for closure size impactEelco Dolstra1-0/+1
2018-05-30use sandbox instead of build-use-sandboxBob van der Linden1-1/+1
2017-10-09pr template: make values of platform field less ambiguousMaxime Dénès1-1/+1
2017-09-03pr template: make formatting consistentPiotr Bogdan1-4/+1
2017-08-12Pull request template: comment out instructionsLinus Heckemann1-1/+1
2017-07-28PULL_REQUEST_TEMPLATE.md: mereley -> merelyYegor Timoshenko1-1/+1
2017-07-22Pull request template: clarify the purpose of the templateFrederik Rietdijk1-0/+2
2017-06-23github/pr-template: Add note about NixOS testsaszlig1-0/+1
On several occasions I've seen people bumping packages which have NixOS tests but without actually running them. While this probably won't prevent such occasions entirely, at least it serves as an additional checklist item so contributors don't forget about these tests. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
2016-11-04Update PULL_REQUEST_TEMPLATE.mdIgnat Loskutov1-1/+1
Follow the rebranding of OS X into macOS
2016-09-02PULL_REQUEST_TEMPLATE: rename chroot to sandboxRushmore Mushambi1-2/+2
See https://github.com/NixOS/nix/commit/b39622a487e2978bd32c9faf2f651aec1f9815c1
2016-06-29PR template: go back to old option name for nowVladimír Čunát1-2/+2
The old one works on all nix(os) versions, whereas the new one doesn't work e.g. on default 16.03 setting. Discussed on #15112.
2016-05-24Update PR template with motivation for changesDaniel Peebles1-0/+3
I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change.
2016-04-26github PR template: reformulate the sandboxing helpVladimír Čunát1-1/+4
It's been reported that when running through nix daemon, sandboxing can't be turned on by passing `--option` (silently ignored), so let's not suggest that way. https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909
2016-04-25nixos: rename chroot* to sandbox*Vladimír Čunát1-1/+1
On Nix side this was done months ago: https://github.com/NixOS/nix/pull/682
2016-04-09Simplify contributingzimbatm1-9/+1
* Highlight the top mistakes directly in CONTRIBUTING.md * Remove unecessary cruft from the PR template
2016-03-16.github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSesNathan Zadoks1-1/+4
2016-02-28PULL_REQUEST_TEMPLATE: fix issues raised in 3c84ae406Domen Kožar1-2/+3
2016-02-28PULL_REQUEST_TEMPLATE.md: clarify a few thingsDomen Kožar1-8/+10
2016-02-22PULL_REQUEST_TEMPLATE: initArseniy Seroka1-0/+15