about summary refs log tree commit diff
path: root/lib
AgeCommit message (Collapse)AuthorFilesLines
2023-12-03lib/customisation: fix eval error (attribute "levenshtein" missing)Someone Serge1-2/+2
2023-12-03lib.systems.elaborate: fix passing `rust` (more) (#271707)Alyssa Ross1-1/+2
An important idea around the rust stuff in lib.systems is that it's elaborated — this means that it should idempotently add to the values passed in, if any. But we missed that the names used for the parameter and the elaborated value for "rustcTarget"/"config" didn't line up. The intention was to use "rustcTarget" everywhere in the new interface, as a more descriptive name than "config". This fixes setting the system in NixOS configuration, which results in an already elaborated system being elaborated again. Before, this wouldn't produce the correct result: % nix-instantiate --eval -A stdenv.hostPlatform.rust.rustcTarget --system armv7l-linux "armv7-unknown-linux-gnueabihf" % NIX_PATH= nix-instantiate --eval -E '(import nixos/lib/eval-config.nix { system = "armv7l-linux"; modules = []; }).pkgs.stdenv.hostPlatform.rust.rustcTarget' "arm-unknown-linux-gnueabihf" Fixes: e3e57b8f1885 ("lib.systems: elaborate Rust metadata") Fixes: https://github.com/NixOS/nixpkgs/issues/271000
2023-12-03lib/customisation: fix callPackage error messagesK9001-2/+3
2023-12-02sudo: fix meta license information (#269788)Pierre Bourdon1-0/+6
2023-11-30lib.customisation.callPackageWith: use throw, not abortAdam Joseph1-1/+3
2023-11-27Merge pull request #270299 from adisbladis/lib-customisation-allocsSilvan Mosberger1-40/+51
lib.customisation: Refactor nested set access & avoid some allocations
2023-11-27Merge pull request #269552 from adisbladis/lib-matchattrs-list-allocsRobert Hensing2-9/+40
lib.attrsets.matchAttrs: Avoid some list allocations when walking structure
2023-11-27lib.customisation: Don't allocate intermediate list for missing argsadisbladis1-3/+3
2023-11-27lib.customisation: Inherit lib/builtins into scopeadisbladis1-39/+50
It makes the code more readable if we have less nested attrsets being accessed.
2023-11-27lib.attrsets.attrByPath: Don't allocate one extra list per lookup recursionadisbladis1-11/+21
Using `tail` in a recursive loop like this needlessly allocates. This changes the loop to look up by list index instead.
2023-11-27lib.attrsets.hasAttrByPath: Don't allocate one extra list per lookup recursionadisbladis1-6/+10
Using `tail` in a recursive loop like this needlessly allocates. This changes the loop to look up by list index instead.
2023-11-26Merge pull request #269637 from adisbladis/lib-meta-avoid-alloc-platformmatchSilvan Mosberger2-10/+42
lib.meta: Avoid attrset allocation in platformMatch
2023-11-27lib.attrsets.matchAttrs: Avoid some list allocations when walking structureadisbladis2-9/+40
Benchmarks (`nix-instantiate ./. -A python3`): - Before: ``` json { "cpuTime": 0.29049500823020935, "envs": { "bytes": 4484216, "elements": 221443, "number": 169542 }, "gc": { "heapSize": 402915328, "totalBytes": 53086800 }, "list": { "bytes": 749424, "concats": 4242, "elements": 93678 }, "nrAvoided": 253991, "nrFunctionCalls": 149848, "nrLookups": 49612, "nrOpUpdateValuesCopied": 1587837, "nrOpUpdates": 10104, "nrPrimOpCalls": 130356, "nrThunks": 358981, "sets": { "bytes": 30423600, "elements": 1859999, "number": 41476 }, "sizes": { "Attr": 16, "Bindings": 16, "Env": 16, "Value": 24 }, "symbols": { "bytes": 236145, "number": 24453 }, "values": { "bytes": 10502520, "number": 437605 } } ``` - After: ``` json { "cpuTime": 0.2946169972419739, "envs": { "bytes": 3315224, "elements": 172735, "number": 120834 }, "gc": { "heapSize": 402915328, "totalBytes": 48718432 }, "list": { "bytes": 347568, "concats": 4242, "elements": 43446 }, "nrAvoided": 173252, "nrFunctionCalls": 101140, "nrLookups": 73595, "nrOpUpdateValuesCopied": 1587837, "nrOpUpdates": 10104, "nrPrimOpCalls": 83067, "nrThunks": 304216, "sets": { "bytes": 29704096, "elements": 1831673, "number": 24833 }, "sizes": { "Attr": 16, "Bindings": 16, "Env": 16, "Value": 24 }, "symbols": { "bytes": 236145, "number": 24453 }, "values": { "bytes": 8961552, "number": 373398 } } ```
2023-11-26acc: init at 1.60Emily Trau1-0/+7
2023-11-25lib.meta: Avoid attrset allocation in platformMatchadisbladis2-10/+42
Benchmarks (`nix-instantiate ./. -A python3`) - Before ``` json { "cpuTime": 0.30625399947166443, "envs": { "bytes": 4484216, "elements": 221443, "number": 169542 }, "gc": { "heapSize": 402915328, "totalBytes": 53091024 }, "list": { "bytes": 749424, "concats": 4242, "elements": 93678 }, "nrAvoided": 253991, "nrFunctionCalls": 149848, "nrLookups": 49614, "nrOpUpdateValuesCopied": 1588326, "nrOpUpdates": 10106, "nrPrimOpCalls": 130356, "nrThunks": 359013, "sets": { "bytes": 30432320, "elements": 1860540, "number": 41480 }, "sizes": { "Attr": 16, "Bindings": 16, "Env": 16, "Value": 24 }, "symbols": { "bytes": 236218, "number": 24459 }, "values": { "bytes": 10504632, "number": 437693 } } ``` - After ``` { "cpuTime": 0.29695799946784973, "envs": { "bytes": 3296712, "elements": 169055, "number": 121517 }, "gc": { "heapSize": 402915328, "totalBytes": 49044992 }, "list": { "bytes": 504928, "concats": 4242, "elements": 63116 }, "nrAvoided": 175403, "nrFunctionCalls": 110554, "nrLookups": 44907, "nrOpUpdateValuesCopied": 1588326, "nrOpUpdates": 10106, "nrPrimOpCalls": 82330, "nrThunks": 306625, "sets": { "bytes": 29943328, "elements": 1843076, "number": 28382 }, "sizes": { "Attr": 16, "Bindings": 16, "Env": 16, "Value": 24 }, "symbols": { "bytes": 236218, "number": 24459 }, "values": { "bytes": 9037752, "number": 376573 } } ```
2023-11-24lib.systems.elaborate: fix passing `rust`Alyssa Ross1-92/+92
Usually, attributes passed explicitly to elaborate take precedence over the elaborated ones, but since we also elaborate the nested "rust" attrset, we need to push that one level down, so the rest of "rust" is still filled in if you just pass { rust = { config = ... } }. I've had to drop the assertion that checked that at most one of "rust" and "rustc" was part of the un-elaborated system, because doing this broke passing an elaborated system in, which should be idempotent. For the same reason, I've also had to make it possible for rust.rustcTargetSpec to be passed in. Otherwise, on the second call, since platform was filled in by the first, the custom target file would be constructed. The only other way to avoid this would be to compare the platform attrs to all built in Rust targets to check it wasn't one of those, and that isn't feasible. Fixes: e3e57b8f1885 ("lib.systems: elaborate Rust metadata")
2023-11-24Merge pull request #266362 from tweag/fileset.fileFilter-extSilvan Mosberger3-3/+46
`lib.fileset.fileFilter`: Predicate attribute for file extension
2023-11-23lib.fileset.fileFilter: Predicate attribute for file extensionSilvan Mosberger3-3/+46
2023-11-22Merge pull request #265964 from tweag/fileset.optionalSilvan Mosberger4-6/+81
`lib.fileset.maybeMissing`: init
2023-11-22lib.fileset: Document decision for strict existence checksSilvan Mosberger1-0/+13
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-11-2124.05 is Uakari 24.05-prefigsoda1-1/+1
2023-11-20lib.fileset.maybeMissing: initSilvan Mosberger4-7/+69
2023-11-20Merge pull request #268619 from tweag/lib-descriptionsSilvan Mosberger7-17/+20
lib: Take advantage of section descriptions
2023-11-20lib: Take advantage of section descriptionsSilvan Mosberger7-17/+20
See https://github.com/nix-community/nixdoc/releases/tag/v2.6.0
2023-11-19lib.fileset: Re-order to match reference overviewSilvan Mosberger1-200/+200
2023-11-19lib.fileset: Add overview section to reference docsSilvan Mosberger1-2/+44
2023-11-19Merge pull request #268520 from tweag/fileset-minor-changesSilvan Mosberger3-6/+11
`lib.fileset`: Minor changes
2023-11-19lib.fileset: Minor changesSilvan Mosberger3-6/+11
- Make fromSource's missing file error message more consistent with others, and add a test for it - Indent some function arguments - Fix an internal type
2023-11-19lib.fileset: Move introduction section above the functionsSilvan Mosberger1-0/+49
Previously the introductory section and the function listings were in different places. But now nixdoc supports having them together with https://github.com/nix-community/nixdoc/pull/70!
2023-11-19Merge pull request #266443 from amjoseph-nixpkgs/pr/lib-tests-no-aws-sdkSilvan Mosberger3-5/+26
2023-11-18lib.tests: build nix without flaky aws-sdk-cppAdam Joseph3-5/+26
The aws-sdk-cpp tests are flaky. Since pull requests to staging cause nix to be rebuilt, this means that staging PRs end up getting false CI failures due to whatever is flaky in the AWS SDK tests. Since none of our CI needs to (or should be able to) contact AWS S3, let's just omit it all. Bonus: the tests build way faster.
2023-11-16Merge master into staging-nextgithub-actions[bot]4-16/+348
2023-11-16lib.fileset.gitTracked: Better error in pure evalSilvan Mosberger2-18/+49
2023-11-16Merge branch 'master' into staging-nextVladimír Čunát4-31/+52
2023-11-16lib.fileset.gitTrackedWith: Introduce recurseSubmodules parameterSilvan Mosberger3-6/+53
2023-11-16lib.fileset.gitTracked/gitTrackedWith: initSilvan Mosberger4-1/+255
A configuration parameter for gitTrackedWith will be introduced in the next commit
2023-11-16Merge pull request #267384 from tweag/fileset.fileFilter-path2Robert Hensing4-31/+52
`fileset.fileFilter`: Restrict second argument to paths
2023-11-15Merge branch 'master' into staging-nextVladimír Čunát6-17/+77
2023-11-15Merge pull request #239722 from Stunkymonkey/lib-allUniqueSilvan Mosberger3-1/+23
lib.lists.allUnique: init
2023-11-15lib.fileset.fileFilter: Restrict second argument to pathsSilvan Mosberger4-31/+52
While this change is backwards-incompatible, I think it's okay because: - The `fileFilter` function is not yet in a stable NixOS release, it was only merged about [a month ago](https://github.com/NixOS/nixpkgs/pull/257356). - All public uses of the function on GitHub only pass a path - Any `fileFilter pred fileset` can also be expressed as `intersection fileset (fileFilter pred path)` without loss of functionality. - This is furthermore pointed out in the new error message when a file set is passed
2023-11-15Merge pull request #267381 from tweag/fileset.fileFilter-pathSilvan Mosberger3-16/+54
`fileset.fileFilter`: Don't run predicate unnecessarily
2023-11-14lib.lists.allUnique: initFelix Buehler3-1/+23
2023-11-14Merge remote-tracking branch 'origin/master' into staging-nextMartin Weinelt1-0/+20
Conflicts: - pkgs/development/libraries/gdcm/default.nix
2023-11-14Merge pull request #263059 from DanielSidhion/add-doc-conventionSilvan Mosberger1-0/+20
doc: commit header convention for documentation changes
2023-11-14lib.fileset.fileFilter: Don't run predicate unnecessarilySilvan Mosberger2-16/+43
Before: nix-repl> fileset.trace (fileset.fileFilter (file: builtins.trace file.name false) ./default.nix) trace: README.md trace: benchmark.sh trace: default.nix trace: internal.nix trace: mock-splitRoot.nix trace: tests.sh After: nix-repl> fileset.trace (fileset.fileFilter (file: builtins.trace file.name false) ./default.nix) trace: default.nix
2023-11-14lib.fileset.fileFilter: Minor cleanups and more testsSilvan Mosberger3-2/+13
2023-11-14Merge master into staging-nextgithub-actions[bot]5-13/+46
2023-11-13doc: separate commit header conventions for each area, info on docs changes.DS1-0/+20
2023-11-14Merge pull request #265710 from ShamrockLee/lib-copy-function-argsSilvan Mosberger3-9/+45
lib.mirrorFunctionArgs: init
2023-11-13lib.fileset: Very minor changesSilvan Mosberger2-4/+1
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-07-03 08:39:34 +0000