| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
* add an example for services.tor.settings.HidServAuth
* fix HidServAuth validation to require ".onion"
Per https://manpages.debian.org/testing/tor/torrc.5.en.html :
> Valid onion addresses contain 16 characters in a-z2-7 plus ".onion"
|
|
nixos/netdata: update configuration
|
|
matrix-dendrite: rename to dendrite
|
|
ssm-agent expects files in /etc/amazon/ssm. The pkg substitutes a location in
the nix store for those default files, but if we ever want to adjust this
configuration on NixOS, we'd need the ability to modify that file.
This change to the nixos module writes copies of the default files from the nix
store to /etc/amazon/ssm. Future versions can add config, but right now this
would allow users to at least write out a text value to
environment.etc."amazon/ssm/amazon-ssm-agent.json".text to provide
their own config.
|
|
iso-image: Fixes for cross-compilation
|
|
sd_image_raspberrypi4: Remove, as planned initially
|
|
|
|
|
|
|
|
|
|
nixos/atd: prefer 'install' over 'mkdir/chmod/chown'
|
|
nixos/wpa_supplicant: prefer 'install' over 'touch/chmod/mkdir/chgrp'
|
|
nixos/tests/unit-php: require one of users.users.name.{isSystemUser,isNormalUser}
|
|
config.boot.kernelPackages.wireguard evaluates to null on machine
closure having a > 5.6 Linux kernels, hence making the evaluation of
this test fail.
Wireguard is now part of the mainline Linux kernel, we do not need to
to add it via a additional kernel module anymore for this test.
|
|
nixos/docker: ensure ipv4 forwarding is enabled
|
|
nixos/sudo: add option execWheelOnly
|
|
users.users.name.{isSystemUser,isNormalUser}
|
|
nixos/tests/docker-tools*: enable linting
|
|
|
|
Annoyed with the interference of the python formatting of
generated code (see #72964), I took matters into my own hands
as maintainer of dockerTools.
Afterwards, I've created a PR, hoping to unstuck the discussion.
@aszlig took notice and thanks to his python ecosystem knowledge,
the testing efforts of @blaggacao and @Ma27, and a sense of
shared suffering and comraderie we were able to change the
situation for the better in #122201.
Now, we have a proper linter that actually helps contributors,
so it's time to turn it back on again.
I'm glad we could make it happen this quickly!
Thanks!
This reverts commit 4035049af3e45554ffc4d8b4c30fd43ae9cd328a.
|
|
There were a bunch of unnecessary f-strings in there and I also removed
the "# fmt: on/off" comments, because we no longer use Black and thus
won't need those comments anymore.
Signed-off-by: aszlig <aszlig@nix.build>
|
|
Signed-off-by: aszlig <aszlig@nix.build>
|
|
|
|
Linter errors reported:
6:32 f-string is missing placeholders
7:26 f-string is missing placeholders
8:32 f-string is missing placeholders
30:32 f-string is missing placeholders
31:26 f-string is missing placeholders
32:32 f-string is missing placeholders
48:32 f-string is missing placeholders
49:26 f-string is missing placeholders
50:32 f-string is missing placeholders
76:32 f-string is missing placeholders
77:26 f-string is missing placeholders
78:32 f-string is missing placeholders
Signed-off-by: aszlig <aszlig@nix.build>
|
|
Signed-off-by: aszlig <aszlig@nix.build>
|
|
Linter error:
use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Signed-off-by: aszlig <aszlig@nix.build>
|
|
Linter error was: f-string is missing placeholders
Signed-off-by: aszlig <aszlig@nix.build>
|
|
|
|
|
|
The new linter basically does
def testScript
# ...
before calling `pyflakes`. As this test-script is empty, it would lead
to a syntax-error unless `pass` is added.
|
|
Note: I didn't execute it entirely because I'd have to build chromium
for this, but the diff appears fine.
|
|
|
|
|
|
Our test driver exposes a bunch of variables and functions, which
pyflakes doesn't recognise by default because it assumes that the test
script is executed standalone. In reality however the test driver script
is using exec() on the testScript.
Fortunately pyflakes has $PYFLAKES_BUILTINS, which are the attributes
that are globally available on all modules to be checked. Since we only
have one module, using this environment variable is fine as opposed to
my first approach to this, which tried to use the unstable internal API
of pyflakes.
The attributes are gathered by the main derivation of the test driver,
because we don't want to end up defining a new attribute in the test
driver module just to being confused why using it in a test will result
in an error.
Another way we could have gathered these attributes would be in
mkDriver, which is where the linting takes place. However, we do have a
different set of Python dependencies in scope and duplicating these will
again just cause confusion over having it at one location only.
Signed-off-by: aszlig <aszlig@nix.build>
Co-Authored-By: aszlig <aszlig@nix.build>
|
|
(cherry picked from commit a2c9220568648b4528154ebd8e657add243ed0b4)
|
|
So far, we have used "black" for formatting the test code, which is
rather strict and opinionated and when used inline in Nix expressions it
creates all sorts of trouble.
One of the main annoyances is that when using strings coming from Nix
expressions (eg. store paths or option definitions from NixOS modules),
completely unrelated changes could cause tests to fail, since eg. black
wants lines to be broken.
Another downside of enforcing a certain kind of formatting is that it
makes the Nix expression code inconsistent because we're mixing two
spaces of indentation (common in nixpkgs) with four spaces of
indentation as defined in PEP-8. While this is perfectly fine for
standalone Python files, it really looks ugly and inconsistent IMO when
used within Nix strings.
What we actually want though is a linter that catches problems early on
before actually running the test, because this is *actually* helping in
development because running the actual VM test takes much longer.
This is the reason why I switched from black to pyflakes, because the
latter actually has useful checks, eg. usage of undefined variables,
invalid format arguments, duplicate arguments, shadowed loop vars and
more.
Signed-off-by: aszlig <aszlig@nix.build>
Closes: https://github.com/NixOS/nixpkgs/issues/72964
|
|
By setting the executable's group to wheel and permissions to 4510, we
make sure that only members of the wheel group can execute sudo.
|
|
|
|
nixos/unbound: allow list of strings in top-level settings option type
|
|
Fixes #118656
|
|
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
|
|
https://hydra.nixos.org/build/142591177/nixlog/30
ZHF: #122042
|
|
nixos/monero: add dataDir option
|
|
dockerTools testing update
|
|
|
|
I should have done this when I became maintainer for dockerTools,
but it's the PR reviews that matter.
|
|
|
|
Remove the opportunity for someone to read the keys in between when
they are written and when the chmod is done. Addresses #121293.
|
|
Since GNOME version is now 40, it no longer makes sense to use the old attribute name.
|
|
lib.meta: introduce `availableOn` to check package availability on given platform
|
