| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
no github handle linked. github account with same name has not had activity for years
|
|
Add the "nas" output plugin. Remove configure flags since those should
get detected automatically. Install bash completions. Format through
nixpkgs-fmt.
|
|
Part of: https://github.com/NixOS/nixpkgs/issues/108938
meta = with stdenv.lib;
is a widely used pattern. We want to slowly remove
the `stdenv.lib` indirection and encourage people
to use `lib` directly. Thus let’s start with the meta
field.
This used a rewriting script to mostly automatically
replace all occurances of this pattern, and add the
`lib` argument to the package header if it doesn’t
exist yet.
The script in its current form is available at
https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix
|
|
This caused none of these flags to have any effect. That's because
the configure command looked like this:
./configure --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 \
--without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n
with one giant flag '--without-test --without-contrib...', containing
internal spaces.
This can be seen in `nix log nixpkgs.gbsplay`, in this line:
configure flags: --prefix=/nix/store/svhl0fjdj1jl2sqcppy5vnzpfi4gj3d3-gbsplay-2016-12-17 --without-test\ --without-contrib\ --disable-devdsp\ --enable-pulse\ --disable-alsa\ --disable-midi\ --disable-nas\ --disable-dsound\ --disable-i18n
and then in the fact that features like "devdsp" and "midi" are listed
as enabled in later output, and source files like plugout_midi.c are
included in the build.
I don't have a real opinion on whether it's better to have these flags
or not, but it's clear the author's intention was to pass them. So,
fix the attr name so they get passed.
|
|
|
|
|
