Age | Commit message (Collapse) | Author | Files | Lines |
|
Co-authored-by: Bobby Rong <rjl931189261@126.com>
|
|
they're unnecessary since https://github.com/NixOS/nixpkgs/pull/161739/files
which links the schemas to their correct fhs locations and adds
gsettings-desktop-schemas and hicolor-icon-theme to appimage fhs
|
|
Notably:
- remove explicit arguments that match the defaults
- convert everything to the right Nix types
|
|
|
|
Upstream changelog https://github.com/ramboxapp/community-edition/releases/tag/0.7.9
|
|
|
|
Rambox hasn't had a stable release in a while and an increasing number
of issues which is why I don't intend to use this anymore.
While taking a closer look at the source I also realized that it uses
Electron 7.2.4[1]. This is not only EOLed[2], it also contains a few
security vulnerabilities which is why I decided to mark it as insecure.
A few (most likely not all) vulnerabilities can be found by looking at
the Electron 7 changelog[3]: after 7.2.4 there were a few more releases
with security backports - mostly from Chromium. Security issues that
were found later on (and are probably exploitable on the dependency
chain of rambox) aren't listed here. I only added two issues that seemed
applicable to `rambox`, but I haven't researched enough to check the
other ones.
[1] https://github.com/ramboxapp/community-edition/blob/0.7.7/package.json#L70
[2] https://www.electronjs.org/docs/tutorial/support#currently-supported-versions
[3] https://www.electronjs.org/releases/stable?version=7
|
|
due to github account removal/deletion and not other mean of contact.
|
|
|
|
|
|
The motivation comes from PR #108787: AppImage is the official and
using it should avoid some issues.
Also, migrating both packages (instead of only rambox-pro like #108787)
can make maintaining both packages better. There is now a `mkRambox`
function that abstract most of the build process.
|
|
Part of: https://github.com/NixOS/nixpkgs/issues/108938
meta = with stdenv.lib;
is a widely used pattern. We want to slowly remove
the `stdenv.lib` indirection and encourage people
to use `lib` directly. Thus let’s start with the meta
field.
This used a rewriting script to mostly automatically
replace all occurances of this pattern, and add the
`lib` argument to the package header if it doesn’t
exist yet.
The script in its current form is available at
https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix
|
|
|
|
|
|
|
|
This will pick the `lib` output if it exists, otherwise default to `out`.
|
|
|
|
+ require explicit version of electron in packages
|
|
|
|
|
|
rambox-pro: fix missing icons, autostart and clean up dir layout
|
|
|
|
|
|
|
|
https://github.com/ramboxapp/community-edition/releases/tag/0.7.5
|
|
https://github.com/ramboxapp/community-edition/releases/tag/0.7.4
|
|
|
|
|
|
|
|
https://github.com/ramboxapp/community-edition/releases/tag/0.7.3
https://github.com/ramboxapp/community-edition/releases/tag/0.7.2
https://github.com/ramboxapp/community-edition/releases/tag/0.7.1
https://github.com/ramboxapp/community-edition/releases/tag/0.7.0
|
|
|
|
|
|
|
|
|
|
|
|
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/rambox-pro/versions
|
|
|
|
There ver very many conflicts, basically all due to
name -> pname+version. Fortunately, almost everything was auto-resolved
by kdiff3, and for now I just fixed up a couple evaluation problems,
as verified by the tarball job. There might be some fallback to these
conflicts, but I believe it should be minimal.
Hydra nixpkgs: ?compare=1538299
|
|
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/rambox-pro/versions
|
|
treewide replacement of
stdenv.mkDerivation rec {
name = "*-${version}";
version = "*";
to pname
|
|
Drop nodejs-8_x
|
|
It will be EOL within the support period of 19.09
|
|
rambox-pro: 1.1.2 -> 1.1.4
|
|
|
|
Fix electron crash when using file chooser dialog
|
|
This is now provided by electron itself.
|
|
This is what upstream uses as well
|
|
|
|
Upgraded the rambox-pro package I previously created from 1.1.2 to 1.1.4 and added necessary changes to accomplish this.
|
|
|