Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
originally done in 62e1d58a6fbced03205afd00ec0e896d2ac26c45
but
reverted in 6d8041b0532c8b51a93f68c9737feecbb195d32a
because it contained many haskell deps
|
|
writeShellApplication: Prefer lib.getExe over unwrapped ShellChecked
|
|
writeShellApplication currently uses the unwrapped (passthru) attribute
which is simply defined as the ShellCheck Haskell package.
Unfortunately the unwrapped version contains everything and the kitchen
sink, while the bin output of the top-level shellcheck package contains
only the static shellcheck executable.
In other words, by using writeShellApplication, currently 3GB of
packages have to be unnecessarily fetched just to run the checkPhase.
$ nix path-info -Sh $(nix build --print-out-paths --no-link nixpkgs#shellcheck.unwrapped)
/nix/store/23x8702b9kqn0r8swah05ky7w5fnh6m2-ShellCheck-0.9.0 3.0G
$ nix path-info -Sh $(nix build --print-out-paths --no-link nixpkgs#shellcheck.bin)
/nix/store/594izb2jz3c57c7hgxfnb6irypnr4575-shellcheck-0.9.0-bin 45.3M
There is no benefit to using shellcheck.unwrapped in this case.
Therefore, replace shellcheck.unwrapped with lib.getExe shellcheck.
|
|
|
|
|
|
|
|
|
|
|
|
* re-format all doc-strings to make them nixdoc compliant
* reformat comments to make them markdown-renderable
|
|
It's very frustrating to try to read through a derivation graph full
of derivations that are all just called "hook", so let's try to avoid
that.
|
|
|
|
writeShellApplication does not need shellcheck docs
it takes ~1 hour to compile the dependencies of pandoc on r9 5900x
because haskell is so slow
$ nix path-info -r ".#sway" --derivation | wc -l
2357
$ nix path-info -r ".#sway" --derivation | wc -l
2055
|
|
|
|
linkFarm: add entries to passthru
|
|
|
|
|
|
trivial-builders.nix: Add input argument `passthru` to makeSetupHook
|
|
|
|
|
|
One significant use case is adding `passthru.tests` to setup-hooks,
and help increase test coverage for mission-critical setup-hooks.
As `meta`, `passthru` doesn't go into the build script directly.
However, passing an empty set to `passthru` breaks nixpkgs-review
and OfBorg tests, so pass it only when specified.
|
|
|
|
the same
when enableParallelBuildingByDefault is enabled
verified with
`nix-diff $(nix eval ".#gcc-unwrapped.drvPath") $(nix eval --expr 'with import ./. { config = { enableParallelBuildingByDefault = true; }; }; gcc-unwrapped.drvPath' --impure)`
|
|
|
|
|
|
writeCBin: fix formatting
|
|
|
|
Co-authored-by: pennae <82953136+pennae@users.noreply.github.com>
|
|
```nix
let pkgs = import ./. {}; in
pkgs.linkFarm "test" [
{ name = "foo"; path = ./README.md; }
]
```
The nix code above generates this result: (`nix build -f test.nix`)
```
lrwxrwxrwx 1 root root 31 Jan 1 1970 /nix/store/98mdz626n99w0467q4r203q154bnnli9-test/foo -> /home/juloo/w/nixpkgs/README.md
```
With this patch, the target file is naturally copied into the store:
```
lrwxrwxrwx 1 root root 53 Jan 1 1970 /nix/store/ndvffnardifqwzbp07g15llav55r5k1m-test/foo -> /nix/store/9rqwjskbbgbflrpyhzi6rak2j7jspr5f-README.md
```
|
|
we will have more testers in the future so they should have their own
location
putting 'testers' in args will also make it simpler to use multiple testers
|
|
|
|
before
$ nix build ".#whipper.tests.version"
whipper> File "/nix/store/2iiyy58pmm1ys6dy8ycbmmmfm67iakv1-whipper-0.10.0/bin/.whipper-wrapped", line 6, in <module>
whipper> File "/nix/store/2iiyy58pmm1ys6dy8ycbmmmfm67iakv1-whipper-0.10.0/lib/python3.9/site-packages/whipper/__init__.py", line 5, in <module>
note: keeping build directory '/tmp/nix-build-whipper-0.10.0-test-version.drv-7'
after
$ nix build ".#whipper.tests.version"
whipper> Traceback (most recent call last):
whipper> File "/nix/store/2iiyy58pmm1ys6dy8ycbmmmfm67iakv1-whipper-0.10.0/bin/.whipper-wrapped", line 6, in <module>
whipper> from whipper.command.main import main
whipper> File "/nix/store/2iiyy58pmm1ys6dy8ycbmmmfm67iakv1-whipper-0.10.0/lib/python3.9/site-packages/whipper/__init__.py", line 5, in <module>
whipper> from pkg_resources import (get_distribution,
whipper> ModuleNotFoundError: No module named 'pkg_resources'
note: keeping build directory '/tmp/nix-build-whipper-0.10.0-test-version.drv-34'
error: builder for '/nix/store/5lxjicdhwgmjcz9ddlxgq3s3gyaa6lz4-whipper-0.10.0-test-version.drv' failed with exit code 1;
|
|
|
|
|
|
|
|
|
|
After being rewritten in https://github.com/NixOS/nixpkgs/pull/149731, this hook
can fail on Mach-O binaries. Since patching ELF files on Darwin doesn't make
much sense anyway, we'll mark this as Linux-exclusive.
|
|
I am sorry.
|
|
; Conflicts:
; nixos/doc/manual/from_md/release-notes/rl-2205.section.xml
; nixos/doc/manual/release-notes/rl-2205.section.md
; pkgs/build-support/libredirect/default.nix
|
|
|
|
Add `shellDryRun` to the generic stdenv and substitute it for uses of
`${stdenv.shell} -n`. The point of this layer of abstraction is to add
the flag `-O extglob`, which resolves #126344 in a more direct way.
|
|
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
|
|
|
|
nixos/networking: using concatTextFile
|
|
|
|
|
|
|
|
|
|
|
|
|