Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2024-03-18 | Merge pull request #296324 from willbush/by-name-update-envc | Silvan Mosberger | 1 | -6/+0 | |
check-by-name: Update .envrc to avoid using deprecated command | |||||
2024-03-16 | check-by-name: Update .envrc to remove deprecated command | Will Bush | 1 | -6/+0 | |
Noticed the following warning: ``` direnv: `nix_direnv_watch_file` is deprecated - use `watch_file` ``` Which seems to come from here: https://github.com/nix-community/nix-direnv/blob/6455f38a8dcf731dccd69aabef3f85ac962bfa8d/direnvrc#L207 Seems this check is no longer needed check-by-name: Remove check from .envrc Co-authored-by: Silvan Mosberger <github@infinisil.com> | |||||
2024-03-12 | Merge master into haskell-updates | github-actions[bot] | 1 | -2/+2 | |
2024-03-06 | check-by-name: Update pinned tooling | Silvan Mosberger | 1 | -2/+2 | |
Includes https://github.com/NixOS/nixpkgs/pull/290743 | |||||
2024-03-03 | Merge master into haskell-updates | github-actions[bot] | 70 | -312/+872 | |
2024-03-02 | Merge pull request #290743 from tweag/by-name-better-errors | Silvan Mosberger | 70 | -312/+872 | |
2024-03-01 | tests.nixpkgs-check-by-name: More inline format! arguments | Silvan Mosberger | 1 | -112/+76 | |
Now that the previous commit removed all the .display()'s that were previously necessary for PathBuf's, but now aren't for RelativePathBuf, we can also inline the format! arguments | |||||
2024-03-01 | tests.nixpkgs-check-by-name: Use RelativePath for relative paths | Silvan Mosberger | 6 | -153/+158 | |
Makes the code easier to understand and less error-prone | |||||
2024-03-01 | tests.nixpkgs-check-by-name: Better empty argument error | Silvan Mosberger | 4 | -0/+12 | |
2024-03-01 | tests.nixpkgs-check-by-name: Fix absolute path in errors | Silvan Mosberger | 5 | -23/+43 | |
2024-03-01 | tests.nixpkgs-check-by-name: Various minor improvements | Silvan Mosberger | 38 | -213/+262 | |
Co-Authored-By: Philip Taron <philip.taron@gmail.com> | |||||
2024-02-29 | Merge master into haskell-updates | github-actions[bot] | 4 | -0/+142 | |
2024-02-29 | substitute: Deprecate `replacements`, introduce `replacementsList` | Silvan Mosberger | 2 | -0/+98 | |
Also: - Add tests - Treewide update - Improve docs | |||||
2024-02-27 | Merge pull request #290946 from ju1m/systemd-option-list | Will Fancher | 3 | -0/+44 | |
nixos/systemd: merge unit options as lists when at least one value is a list | |||||
2024-02-25 | nixos/systemd: merge unit options as lists when at least one value is a list | Julien Moutinho | 3 | -0/+44 | |
2024-02-25 | Merge master into haskell-updates | github-actions[bot] | 1 | -1/+16 | |
2024-02-23 | tests.nixpkgs-check-by-name: Fix internal docs | Silvan Mosberger | 1 | -2/+5 | |
2024-02-23 | tests.nixpkgs-check-by-name: Improve errors for new packages | Silvan Mosberger | 6 | -23/+75 | |
Or rather, make it more consistent | |||||
2024-02-23 | tests.nixpkgs-check-by-name: More spaces in errors | Silvan Mosberger | 9 | -5/+19 | |
2024-02-23 | tests.nixpkgs-check-by-name: Better error for empty second arg | Silvan Mosberger | 7 | -25/+77 | |
2024-02-23 | tests.nixpkgs-check-by-name: More consistent errors | Silvan Mosberger | 6 | -8/+8 | |
2024-02-23 | tests.nixpkgs-check-by-name: Evaluate base and main branch in parallel | Silvan Mosberger | 1 | -7/+13 | |
2024-02-23 | tests.nixpkgs-check-by-name: Improve errors relating to the base branch | Silvan Mosberger | 55 | -37/+110 | |
2024-02-23 | tests.nixpkgs-check-by-name: Improve more errors | Silvan Mosberger | 10 | -54/+134 | |
2024-02-22 | tests.nixpkgs-check-by-name: Improve non-syntactic callPackage error more | Silvan Mosberger | 6 | -14/+79 | |
2024-02-22 | tests.nixpkgs-check-by-name: Improve error for wrong package file | Silvan Mosberger | 6 | -31/+106 | |
2024-02-19 | tests.nixpkgs-check-by-name: Better error for non-syntactic callPackage | Silvan Mosberger | 5 | -53/+111 | |
2024-02-19 | tests.nixpkgs-check-by-name: Fix allowing non-path overrides | Silvan Mosberger | 5 | -18/+26 | |
An edge case was allowed when it shouldn't be: A package defined in `pkgs/by-name` could be overridden in `all-packages.nix` if it was of the form `callPackage (<expr>) { <non-empty> }`. This is not right, it's required that the first argument be the path matching the package to be overridden. | |||||
2024-02-19 | tests.nixpkgs-check-by-name: Improve inherit detection | Silvan Mosberger | 1 | -6/+30 | |
Detect inherit's better, such that a future commit can use this information in an error message | |||||
2024-02-18 | Merge master into haskell-updates | github-actions[bot] | 1 | -0/+1 | |
2024-02-17 | Merge staging-next into staging | github-actions[bot] | 1 | -0/+1 | |
2024-02-17 | fetchPypiLegacy: add test | DavHau | 1 | -0/+1 | |
2024-02-16 | Merge pull request #255463 from ↵ | Rick van Schijndel | 1 | -1/+16 | |
emilylange/stdenv/patch-shebangs-trailing-newline patch-shebangs: fix crash with shebang without trailing newline | |||||
2024-02-13 | Merge master into haskell-updates | github-actions[bot] | 1 | -2/+2 | |
2024-02-12 | check-by-name: Update pinned tooling | Silvan Mosberger | 1 | -2/+2 | |
Includes https://github.com/NixOS/nixpkgs/pull/287083 | |||||
2024-02-10 | Merge master into haskell-updates | github-actions[bot] | 1 | -2/+2 | |
2024-02-09 | check-by-name: Update pinned tool | Silvan Mosberger | 1 | -2/+2 | |
Includes https://github.com/NixOS/nixpkgs/pull/285089 | |||||
2024-02-09 | Merge master into haskell-updates | github-actions[bot] | 14 | -220/+351 | |
2024-02-08 | tests.nixpkgs-check-by-name: Test against sbcl-like regression | Silvan Mosberger | 4 | -0/+9 | |
This adds a test to check that a commit like 0a3dab4af34e4d086931d82827bfc8760c3e3150 would fail CI After doing some improvements to the `pkgs/by-name` check I discovered that sbcl shouldn't have been allowed in `pkgs/by-name` after all as is. Specifically, the requirement is that if `pkgs/by-name/sb/sbcl` exists, the definition of the `sbcl` attribute must look like sbcl = callPackage ../by-name/sb/sbcl/package.nix { ... }; However it currently is an alias like sbcl = sbcl_2_4_1; This wasn't detected before because `sbcl_2_4_1` was semantically defined using `callPackage`: sbcl_2_4_1 = wrapLisp { pkg = callPackage ../development/compilers/sbcl { version = "2.4.1"; }; faslExt = "fasl"; flags = [ "--dynamic-space-size" "3000" ]; }; However this doesn't syntactically match what is required. In https://github.com/NixOS/nixpkgs/pull/285089 I introduced syntactic checks for exactly this, but they were only used for packages not already in `pkgs/by-name`. Only now that I'm doing the refactoring to also use this check for `pkgs/by-name` packages this problem is noticed. While introducing this new check is technically an increase in strictness, and therefore would justify adding a new ratchet, I consider this case to be rare enough that we don't need to do that. This commit introduces a test to prevent such regressions in the future Moving sbcl back out of `pkgs/by-name` will be done when the pinned CI is updated | |||||
2024-02-08 | tests.nixpkgs-check-by-name: Improve code | Silvan Mosberger | 5 | -221/+335 | |
- Detect manual use of _internalCallByNamePackageFile for packages in `pkgs/by-name` (can't be done for others though) - Separate error message for when attribute locations can't be determined for `pkgs/by-name` attributes - Much better structure of the code in eval.rs, representing more closely what is being checked - Much more extensive comments | |||||
2024-02-08 | tests.nixpkgs-check-by-name: More tests | Silvan Mosberger | 6 | -0/+8 | |
For some previously untested cases. In a future commit, those tests will also be adjusted slightly | |||||
2024-02-06 | Merge master into haskell-updates | github-actions[bot] | 21 | -243/+901 | |
2024-02-05 | Merge pull request #285089 from tweag/by-name-syntactic-callPackage | Silvan Mosberger | 21 | -243/+901 | |
tests.nixpkgs-check-by-name: Syntactic `callPackage` detection and allow new package variants | |||||
2024-02-05 | tests.nixpkgs-check-by-name: Refactor eval.rs | Silvan Mosberger | 1 | -176/+202 | |
There was too much indentation! | |||||
2024-02-05 | tests.nixpkgs-check-by-name: Apply feedback from review | Silvan Mosberger | 7 | -274/+247 | |
https://github.com/NixOS/nixpkgs/pull/285089#pullrequestreview-1861099233 Many thanks, Philip Taron! | |||||
2024-02-01 | Merge master into haskell-updates | github-actions[bot] | 2 | -0/+86 | |
2024-01-31 | Merge pull request #279844 from doronbehar/tests/buildFHSEnv | Atemu | 2 | -0/+86 | |
tests.buildFHSEnv.libtinfo: init | |||||
2024-01-31 | Merge master into haskell-updates | github-actions[bot] | 1 | -2/+2 | |
2024-01-30 | tests.nixpkgs-check-by-name: Allow new package variants | Silvan Mosberger | 8 | -1/+35 | |
2024-01-30 | tests.nixpkgs-check-by-name: Format | Silvan Mosberger | 3 | -77/+172 | |
With `cargo fmt` Explicitly didn't do that for previous commits in order to keep the diff more easily reviewable |