about summary refs log tree commit diff
path: root/pkgs/development/python-modules/cffi/default.nix
blob: 83c955b3c1c07a8ae9bb716d1c637f692a26194b (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
{
  lib,
  stdenv,
  buildPythonPackage,
  isPyPy,
  fetchPypi,
  fetchpatch2,
  setuptools,
  pytestCheckHook,
  libffi,
  pkg-config,
  pycparser,
  pythonAtLeast,
}:

let
  ccVersion = lib.getVersion stdenv.cc;
in
if isPyPy then
  null
else
  buildPythonPackage rec {
    pname = "cffi";
    version = "1.16.0";
    pyproject = true;

    src = fetchPypi {
      inherit pname version;
      hash = "sha256-vLPvQ+WGZbvaL7GYaY/K5ndkg+DEpjGqVkeAbCXgLMA=";
    };

    patches =
      [
        #
        # Trusts the libffi library inside of nixpkgs on Apple devices.
        #
        # Based on some analysis I did:
        #
        #   https://groups.google.com/g/python-cffi/c/xU0Usa8dvhk
        #
        # I believe that libffi already contains the code from Apple's fork that is
        # deemed safe to trust in cffi.
        #
        ./darwin-use-libffi-closures.diff

        (fetchpatch2 {
          # https://github.com/python-cffi/cffi/pull/34
          name = "python-3.13-compat-1.patch";
          url = "https://github.com/python-cffi/cffi/commit/49127c6929bfc7186fbfd3819dd5e058ad888de4.patch";
          hash = "sha256-RbspsjwDf4uwJxMqG0JZGvipd7/JqXJ2uVB7PO4Qcms=";
        })
        (fetchpatch2 {
          # https://github.com/python-cffi/cffi/pull/24
          name = "python-3.13-compat-2.patch";
          url = "https://github.com/python-cffi/cffi/commit/14723b0bbd127790c450945099db31018d80fa83.patch";
          hash = "sha256-H5rFgRRTr27l5S6REo8+7dmPDQW7WXhP4f4DGZjdi+s=";
        })
      ]
      ++ lib.optionals (stdenv.cc.isClang && (ccVersion == "boot" || lib.versionAtLeast ccVersion "13")) [
        # -Wnull-pointer-subtraction is enabled with -Wextra. Suppress it to allow the following tests
        # to run and pass when cffi is built with newer versions of clang (including the bootstrap tools clang on Darwin):
        # - testing/cffi1/test_verify1.py::test_enum_usage
        # - testing/cffi1/test_verify1.py::test_named_pointer_as_argument
        ./clang-pointer-substraction-warning.diff
      ];

    postPatch = lib.optionalString stdenv.isDarwin ''
      # Remove setup.py impurities
      substituteInPlace setup.py \
        --replace "'-iwithsysroot/usr/include/ffi'" "" \
        --replace "'/usr/include/ffi'," "" \
        --replace '/usr/include/libffi' '${lib.getDev libffi}/include'
    '';

    nativeBuildInputs = [
      pkg-config
      setuptools
    ];

    buildInputs = [ libffi ];

    propagatedBuildInputs = [ pycparser ];

    # The tests use -Werror but with python3.6 clang detects some unreachable code.
    env.NIX_CFLAGS_COMPILE = lib.optionalString stdenv.cc.isClang "-Wno-unused-command-line-argument -Wno-unreachable-code -Wno-c++11-narrowing";

    doCheck = !stdenv.hostPlatform.isMusl;

    nativeCheckInputs = [ pytestCheckHook ];

    meta = with lib; {
      changelog = "https://github.com/python-cffi/cffi/releases/tag/v${version}";
      description = "Foreign Function Interface for Python calling C code";
      downloadPage = "https://github.com/python-cffi/cffi";
      homepage = "https://cffi.readthedocs.org/";
      license = licenses.mit;
      maintainers = teams.python.members;
    };
  }