about summary refs log tree commit diff
path: root/machines
diff options
context:
space:
mode:
authoraszlig <aszlig@nix.build>2022-09-28 11:10:44 +0200
committeraszlig <aszlig@nix.build>2022-09-28 11:36:08 +0200
commite0685e81b3fdc43a272f0d5c3c0ab4ad5ed5a797 (patch)
tree127b6dbf5b16ef421a85330ed00ab072fa756bc6 /machines
parent770619fee4e91a74ba0a6ad83c176af2f1a5e9c6 (diff)
channel: Fix exposing meta.isHydraChannel
The isHydraChannel meta attribute is needed in order to tell Hydra that
the derivation in question should be a channel tarball. However in
Nixpkgs the meta attribute is not used, so checkMeta doesn't recognise
it as a valid attribute which leads to an evaluation error.

Recently[1] a commit got merged, which enables shallow type checking for
meta attributes by default. This led to an evaluation error for our
Hydra machine channels for the reason mentioned above.

I opted to work around that issue by adding meta.isHydraChannel after
mkDerivation, because adding isHydraChannel as a valid meta attribute to
Nixpkgs doesn't feel right to me since it's only relevant for Hydra and
its apparently deprecated[2] channel feature.

[1]: https://github.com/NixOS/nixpkgs/commit/6762de9a28e248f46bd0810e03c
[2]: https://github.com/NixOS/hydra/blob/53335323ae79ca1a42643f58e520b376898ce641/doc/manual/src/jobs.md#meta-fields

Signed-off-by: aszlig <aszlig@nix.build>
Diffstat (limited to 'machines')
0 files changed, 0 insertions, 0 deletions