diff options
author | Sergei Trofimovich <slyich@gmail.com> | 2022-11-08 10:35:09 +0000 |
---|---|---|
committer | Sergei Trofimovich <slyich@gmail.com> | 2022-11-08 10:35:09 +0000 |
commit | 4e6dd2e77851a9e1f186728951d2a61079c0d193 (patch) | |
tree | 48fd7dc68e2346afa389a420ae9869a2278e29d0 | |
parent | 093268502280540a7f5bf1e2a6330a598ba3b7d0 (diff) |
fwbuilder: disable blanket `-Werror`
`-Werror` flag usually causes build failures due to minor changes in compiler versions. They might be useful for developers themselves but are rarely useful for distributions. last time `fwbuilder` failed the build against newer `libxml2`: libfwbuilder/src/fwbuilder/XMLTools.cpp: In static member function 'static void libfwbuilder::XMLTools::initXMLTools()': libfwbuilder/src/fwbuilder/XMLTools.cpp:222:18: error: 'int xmlInitMemory()' is deprecated [-Werror=deprecated-declarations] 222 | xmlInitMemory(); | ~~~~~~~~~~~~~^~
-rw-r--r-- | pkgs/tools/security/fwbuilder/default.nix | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/pkgs/tools/security/fwbuilder/default.nix b/pkgs/tools/security/fwbuilder/default.nix index bbc6d3b551536..6787e2f923b9f 100644 --- a/pkgs/tools/security/fwbuilder/default.nix +++ b/pkgs/tools/security/fwbuilder/default.nix @@ -20,6 +20,13 @@ stdenv.mkDerivation rec { hash = "sha256-j5HjGcIqq93Ca9OBqEgSotoSXyw+q6Fqxa3hKk1ctwQ="; }; + postPatch = '' + # Avoid blanket -Werror as it triggers on any minor compiler + # warnings like deprecated functions or invalid indentat8ion. + # Leave fixing these problems to upstream. + substituteInPlace CMakeLists.txt --replace ';-Werror;' ';' + ''; + nativeBuildInputs = [ cmake ninja @@ -32,11 +39,6 @@ stdenv.mkDerivation rec { qtwayland ]; - NIX_CFLAGS_COMPILE = [ - "-Wno-error=misleading-indentation" - "-Wno-error=deprecated-declarations" - ]; - meta = with lib; { description = "GUI Firewall Management Application"; longDescription = '' |