diff options
| author | github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> | 2023-07-16 18:01:40 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-16 18:01:40 +0000 |
| commit | 034c3854f0b994f4ff0930ec8fbcc259b6d97566 (patch) | |
| tree | 1d2a505453b152ff38b356160267aa87d4d5a5b8 /doc | |
| parent | a0072edeba87f3545eef84dc823452505146de7a (diff) | |
| parent | d4613a1d4538bdd4403d6864d3c2ebee00d9b401 (diff) | |
Merge staging-next into staging
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/contributing/reviewing-contributions.chapter.md | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/doc/contributing/reviewing-contributions.chapter.md b/doc/contributing/reviewing-contributions.chapter.md index b4caf11f6d4bf..10c72fe3d13ec 100644 --- a/doc/contributing/reviewing-contributions.chapter.md +++ b/doc/contributing/reviewing-contributions.chapter.md @@ -62,6 +62,8 @@ Sample template for a package update review is provided below. - [ ] package build on ARCHITECTURE - [ ] executables tested on ARCHITECTURE - [ ] all depending packages build +- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed +- [ ] patches that are remotely available are fetched rather than vendored ##### Possible improvements @@ -105,7 +107,8 @@ Sample template for a new package review is provided below. - [ ] source is fetched using the appropriate function - [ ] the list of `phases` is not overridden - [ ] when a phase (like `installPhase`) is overridden it starts with `runHook preInstall` and ends with `runHook postInstall`. -- [ ] patches that are remotely available are fetched with `fetchpatch` +- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed +- [ ] patches that are remotely available are fetched rather than vendored ##### Possible improvements |