diff options
| author | Robert Hensing <roberth@users.noreply.github.com> | 2023-06-27 15:56:54 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-27 15:56:54 +0200 |
| commit | 4920af40fce2c56ae2c4fd08ad1ff8b6f1dc80b1 (patch) | |
| tree | d1f0e5009d0e84d10cce6b22ef0f50634e3414c0 /doc | |
| parent | bc152fd1c1194099c610bce9d30f1bc9fd3cc09e (diff) | |
doc/reviewing-contributions: Add points about patches
A weaker version of https://github.com/NixOS/nixpkgs/pull/186484#issuecomment-1608960696
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/contributing/reviewing-contributions.chapter.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/contributing/reviewing-contributions.chapter.md b/doc/contributing/reviewing-contributions.chapter.md index b4caf11f6d4bf..7ee37863c2041 100644 --- a/doc/contributing/reviewing-contributions.chapter.md +++ b/doc/contributing/reviewing-contributions.chapter.md @@ -62,6 +62,8 @@ Sample template for a package update review is provided below. - [ ] package build on ARCHITECTURE - [ ] executables tested on ARCHITECTURE - [ ] all depending packages build +- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed +- [ ] patches that are remotely available are fetched with `fetchpatch` ##### Possible improvements @@ -105,6 +107,7 @@ Sample template for a new package review is provided below. - [ ] source is fetched using the appropriate function - [ ] the list of `phases` is not overridden - [ ] when a phase (like `installPhase`) is overridden it starts with `runHook preInstall` and ends with `runHook postInstall`. +- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed - [ ] patches that are remotely available are fetched with `fetchpatch` ##### Possible improvements |