about summary refs log tree commit diff
path: root/lib/modules.nix
diff options
context:
space:
mode:
authorSilvan Mosberger <contact@infinisil.com>2020-03-19 03:48:46 +0100
committerSilvan Mosberger <contact@infinisil.com>2020-03-19 03:50:15 +0100
commit9eecf2d05711b8e8677af8ceda17f6b9938b3eb3 (patch)
tree4bc1c405c48d507f6260d675ca57ac6ce861abe1 /lib/modules.nix
parentd0cf54223cc49e49b718472457b6da053d1fdc7e (diff)
Revert "lib/modules: Throw better error when definitions assign to an option set"
This reverts commit 15c873b486347e7861c64fb0b5a7852be9fc82e4.

This was causing infinite recursion when depending on nested options
Diffstat (limited to 'lib/modules.nix')
-rw-r--r--lib/modules.nix4
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/modules.nix b/lib/modules.nix
index 518f4047cc60d..c18fec66c7056 100644
--- a/lib/modules.nix
+++ b/lib/modules.nix
@@ -299,9 +299,7 @@ rec {
             in
               throw "The option `${showOption loc}' in `${firstOption._file}' is a prefix of options in `${firstNonOption._file}'."
           else
-            if all (def: isAttrs def.value) defns' then mergeModules' loc decls defns
-            else let firstInvalid = findFirst (def: ! isAttrs def.value) null defns';
-            in throw "The option path `${showOption loc}' is an attribute set of options, but it is defined to not be an attribute set in `${firstInvalid.file}'. Did you define its value at the correct and complete path?"
+            mergeModules' loc decls defns
       ))
     // { _definedNames = map (m: { inherit (m) file; names = attrNames m.config; }) configs; };