about summary refs log tree commit diff
path: root/nixos/tests/herbstluftwm.nix
diff options
context:
space:
mode:
authorAndreas Rammhold <andreas@rammhold.de>2021-08-27 01:47:27 +0200
committerAndreas Rammhold <andreas@rammhold.de>2021-09-12 23:45:55 +0200
commit72197a5c790230a007a570017ef58bb26f45fe96 (patch)
tree2a5d2d021dec8b1eca070344245cc867dd9b9642 /nixos/tests/herbstluftwm.nix
parent64556974b6674338a227d559975c9b4710f6e751 (diff)
nixos/tests/herbstluftwm: fix timeout that was given in seconds
Hydra accepts timeouts as value of seconds after which the test is
terminated / considered failed. Using the value 30 here has the effect
that the test was terminate after 30 seconds. That time might be
sufficient for the test execution itself but it has another downside:

Jobs on hydra inherit the timeout of their parent. In this case all the
builds that are a dependency of the herbstluftwm test *must* finish
(each) within 30s. And since not all of the dependencies are cached in
the binary cache this could lead to an issue with pacakges that take
longer than 30s to build at the time when the herbstluftwm test is built
by hydra.

It is best to not set the timeout here and let hydra deal with it.  Our
default timeout for builds is two hours which is more than sufficient
for most builds and tests. If the test fails we will spent ~2h doing
something or nothing at worst but at least we wont kill the build just
because a dependency wasn't fullfilled already.
Diffstat (limited to 'nixos/tests/herbstluftwm.nix')
-rw-r--r--nixos/tests/herbstluftwm.nix1
1 files changed, 0 insertions, 1 deletions
diff --git a/nixos/tests/herbstluftwm.nix b/nixos/tests/herbstluftwm.nix
index 2c98cceee6a21..7d079f4bfb695 100644
--- a/nixos/tests/herbstluftwm.nix
+++ b/nixos/tests/herbstluftwm.nix
@@ -3,7 +3,6 @@ import ./make-test-python.nix ({ lib, ...} : {
 
   meta = {
     maintainers = with lib.maintainers; [ thibautmarty ];
-    timeout = 30;
   };
 
   machine = { pkgs, lib, ... }: {