about summary refs log tree commit diff
path: root/nixos
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2019-12-31 14:41:58 +0100
committerGitHub <noreply@github.com>2019-12-31 14:41:58 +0100
commitd6bbe6c0f5c27014801008280faaa0e50e00a50b (patch)
tree850ad52259494508ad2a95d9b9a1c0dbc9b4485d /nixos
parent2e6f703473796e85b24f23408fdc781794f2d325 (diff)
parent90a3908ec333a47232b520d8f5c7f2680f348fea (diff)
Merge pull request #76719 from flokli/containers-poweroff
nixos/containers: use machinectl poweroff
Diffstat (limited to 'nixos')
-rw-r--r--nixos/modules/virtualisation/containers.nix15
1 files changed, 1 insertions, 14 deletions
diff --git a/nixos/modules/virtualisation/containers.nix b/nixos/modules/virtualisation/containers.nix
index 09678ce9ea716..02de5801da253 100644
--- a/nixos/modules/virtualisation/containers.nix
+++ b/nixos/modules/virtualisation/containers.nix
@@ -225,12 +225,6 @@ let
           fi
           ${concatStringsSep "\n" (mapAttrsToList renderExtraVeth cfg.extraVeths)}
         fi
-
-        # Get the leader PID so that we can signal it in
-        # preStop. We can't use machinectl there because D-Bus
-        # might be shutting down. FIXME: in systemd 219 we can
-        # just signal systemd-nspawn to do a clean shutdown.
-        machinectl show "$INSTANCE" | sed 's/Leader=\(.*\)/\1/;t;d' > "/run/containers/$INSTANCE.pid"
       ''
   );
 
@@ -715,14 +709,7 @@ in
 
       postStart = postStartScript dummyConfig;
 
-      preStop =
-        ''
-          pid="$(cat /run/containers/$INSTANCE.pid)"
-          if [ -n "$pid" ]; then
-            kill -RTMIN+4 "$pid"
-          fi
-          rm -f "/run/containers/$INSTANCE.pid"
-        '';
+      preStop = "machinectl poweroff $INSTANCE";
 
       restartIfChanged = false;