about summary refs log tree commit diff
path: root/pkgs/applications/networking/browsers/google-chrome
diff options
context:
space:
mode:
authorAlyssa Ross <hi@alyssa.is>2019-11-06 19:37:25 +0000
committerFlorian Klink <flokli@flokli.de>2020-09-05 11:20:13 +0200
commitde69b705d2afe755007a923ec5ab103c18cfa566 (patch)
tree91e39d5eb7532f9692b06e1e68d6a37a294f1fa7 /pkgs/applications/networking/browsers/google-chrome
parent5811b6c1cd8b3a8c45e90945110461ca21c3616b (diff)
chromium: replace update.nix with Python impl
update.nix was a huuuuge hack, abusing checksum collisions, etc., and
was extremely difficult to read and maintain, especially because
values from update.nix were also used in the derivations themselves!

I've replaced this with an implementation in Python, which I chose for
readability.  Rather than generating Nix, I chose to
generate JSON, since Python can do that in the standard library and
Nix can read it.

I also set update.py as an updateScript, so Chromium can now
automatically be updated!

Fixes: https://github.com/NixOS/nixpkgs/issues/89635
Diffstat (limited to 'pkgs/applications/networking/browsers/google-chrome')
-rw-r--r--pkgs/applications/networking/browsers/google-chrome/default.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/pkgs/applications/networking/browsers/google-chrome/default.nix b/pkgs/applications/networking/browsers/google-chrome/default.nix
index fa19c4efa9d8f..4d985e33e6b24 100644
--- a/pkgs/applications/networking/browsers/google-chrome/default.nix
+++ b/pkgs/applications/networking/browsers/google-chrome/default.nix
@@ -72,7 +72,7 @@ in stdenv.mkDerivation {
 
   name = "google-chrome${suffix}-${version}";
 
-  src = chromium.upstream-info.binary;
+  src = chromium.chromeSrc;
 
   nativeBuildInputs = [ patchelf makeWrapper ];
   buildInputs = [