about summary refs log tree commit diff
path: root/pkgs/applications/networking/instant-messengers/nheko
diff options
context:
space:
mode:
authorDoron Behar <doron.behar@gmail.com>2020-04-30 10:25:38 +0300
committerDoron Behar <doron.behar@gmail.com>2020-04-30 10:30:52 +0300
commitbdcbfc77c9bda30964d00b41b4c906aa9d489967 (patch)
tree6057444f3768a675ba26909169be0e772258e3be /pkgs/applications/networking/instant-messengers/nheko
parent0577b994afe04a188319acc9319d6794224ba415 (diff)
nheko && mtxclient: enable for Darwin but mark as broken
Diffstat (limited to 'pkgs/applications/networking/instant-messengers/nheko')
-rw-r--r--pkgs/applications/networking/instant-messengers/nheko/default.nix21
1 files changed, 4 insertions, 17 deletions
diff --git a/pkgs/applications/networking/instant-messengers/nheko/default.nix b/pkgs/applications/networking/instant-messengers/nheko/default.nix
index cab4889c231f1..f3b304564cbe5 100644
--- a/pkgs/applications/networking/instant-messengers/nheko/default.nix
+++ b/pkgs/applications/networking/instant-messengers/nheko/default.nix
@@ -33,22 +33,6 @@ mkDerivation rec {
     sha256 = "12sxibbrn79sxkf9jrm7jrlj7l5vz15claxrrll7pkv9mv44wady";
   };
 
-  # If, on Darwin, you encounter the error
-  #   error: must specify at least one argument for '...' parameter of variadic
-  #   macro [-Werror,-Wgnu-zero-variadic-macro-arguments]
-  # Then adding this parameter is likely the fix you want.
-  #
-  # However, it looks like either cmake doesn't honor this CFLAGS variable, or
-  # darwin's compiler doesn't have the same syntax as gcc for turning off
-  # -Werror selectively.
-  #
-  # Anyway, this is something that will have to be debugged with access to a
-  # darwin-based OS. Sorry about that!
-  #
-  #preConfigure = lib.optionalString stdenv.isDarwin ''
-  #  export CFLAGS=-Wno-error=gnu-zero-variadic-macro-arguments
-  #'';
-
   nativeBuildInputs = [
     lmdbxx
     cmake
@@ -89,7 +73,10 @@ mkDerivation rec {
     description = "Desktop client for the Matrix protocol";
     homepage = "https://github.com/Nheko-Reborn/nheko";
     maintainers = with maintainers; [ ekleog fpletz ];
-    platforms = platforms.unix;
+    platforms = platforms.all;
+    # Should be fixable if a higher clang version is used, see:
+    # https://github.com/NixOS/nixpkgs/pull/85922#issuecomment-619287177
+    broken = stdenv.targetPlatform.isDarwin;
     license = licenses.gpl3Plus;
   };
 }