about summary refs log tree commit diff
path: root/pkgs/development/libraries/jsoncpp
diff options
context:
space:
mode:
authorElliot Cameron <nixpkgs-commits@deshaw.com>2023-04-21 00:39:40 -0400
committerElliot Cameron <nixpkgs-commits@deshaw.com>2023-07-26 16:11:25 -0400
commit40f8d8b2569f11e0be3f734efd74f5e5e0b96ab5 (patch)
treec5e8c85cf24b70c237fccc4b54c59e48e2e399f6 /pkgs/development/libraries/jsoncpp
parentfa9859507ba72b72f157b42da4ef0cc89a082074 (diff)
jsoncpp: fix enableStatic
The workaround is no longer needed for static builds.
Diffstat (limited to 'pkgs/development/libraries/jsoncpp')
-rw-r--r--pkgs/development/libraries/jsoncpp/default.nix10
1 files changed, 2 insertions, 8 deletions
diff --git a/pkgs/development/libraries/jsoncpp/default.nix b/pkgs/development/libraries/jsoncpp/default.nix
index 41e9a2d0a03ad..59572afc627ce 100644
--- a/pkgs/development/libraries/jsoncpp/default.nix
+++ b/pkgs/development/libraries/jsoncpp/default.nix
@@ -40,19 +40,13 @@ stdenv.mkDerivation rec {
     "-DBUILD_SHARED_LIBS=ON"
     "-DBUILD_OBJECT_LIBS=OFF"
     "-DJSONCPP_WITH_CMAKE_PACKAGE=ON"
+    "-DBUILD_STATIC_LIBS=${if enableStatic then "ON" else "OFF"}"
   ]
     # the test's won't compile if secureMemory is used because there is no
     # comparison operators and conversion functions between
     # std::basic_string<..., Json::SecureAllocator<char>> vs.
     # std::basic_string<..., [default allocator]>
-    ++ lib.optional ((stdenv.buildPlatform != stdenv.hostPlatform) || secureMemory) "-DJSONCPP_WITH_TESTS=OFF"
-    ++ lib.optional (!enableStatic) "-DBUILD_STATIC_LIBS=OFF";
-
-  # this is fixed and no longer necessary in 1.9.5 but there they use
-  # memset_s without switching to a different c++ standard in the cmake files
-  postInstall = lib.optionalString enableStatic ''
-    (cd $out/lib && ln -sf libjsoncpp_static.a libjsoncpp.a)
-  '';
+    ++ lib.optional ((stdenv.buildPlatform != stdenv.hostPlatform) || secureMemory) "-DJSONCPP_WITH_TESTS=OFF";
 
   meta = with lib; {
     homepage = "https://github.com/open-source-parsers/jsoncpp";