about summary refs log tree commit diff
path: root/pkgs/development/python-modules/pkgconfig
diff options
context:
space:
mode:
authorSpencer Baugh <sbaugh@catern.com>2019-02-12 19:17:05 +0000
committerFrederik Rietdijk <fridh@fridh.nl>2019-02-17 14:40:51 +0100
commit46f2b49b443a78b4d686827192aaf79df87a6f1e (patch)
tree90bfbf9e609e20349e634ac49718aa71d2899cc0 /pkgs/development/python-modules/pkgconfig
parent50b1d64534b6d648a7a579b987577442fcea2c29 (diff)
pythonPackages.pkgconfig: use same setupHook as pkgconfig
This setupHook is necessary for actually using pkgconfig. Without this
setupHook, you need to put both pythonPackages.pkgconfig and pkgconfig
into your buildInputs, just to get the setuphook of the latter.

Previously, pythonPackages.pkgconfig depended on pkgconfig as a
propagatedBuildInput, so this setupHook was propagated down to
dependents. That was changed to a regular nativeBuildInput, so now
this setupHook change is necessary for packages to only depend on
pythonPackages.pkgconfig.

A possible alternative is extracting out a common pkgconfigHook
package and having both pythonPackages.pkgconfig and pkgconfig depend
on that with propagatedBuildInputs. That might be necessary to avoid
the buildHook running twice?
Diffstat (limited to 'pkgs/development/python-modules/pkgconfig')
-rw-r--r--pkgs/development/python-modules/pkgconfig/default.nix2
1 files changed, 2 insertions, 0 deletions
diff --git a/pkgs/development/python-modules/pkgconfig/default.nix b/pkgs/development/python-modules/pkgconfig/default.nix
index 38098b432e459..ab8c2f638b410 100644
--- a/pkgs/development/python-modules/pkgconfig/default.nix
+++ b/pkgs/development/python-modules/pkgconfig/default.nix
@@ -4,6 +4,8 @@ buildPythonPackage rec {
   pname = "pkgconfig";
   version = "1.4.0";
 
+  setupHook = pkgconfig.setupHook;
+
   src = fetchPypi {
     inherit pname version;
     sha256 = "048c3b457da7b6f686b647ab10bf09e2250e4c50acfe6f215398a8b5e6fcdb52";