about summary refs log tree commit diff
path: root/pkgs
diff options
context:
space:
mode:
authorPhillip Cloud <417981+cpcloud@users.noreply.github.com>2022-02-17 06:52:28 -0500
committerJonathan Ringer <jonringer@users.noreply.github.com>2022-02-17 08:24:38 -0800
commit1c848adb7ac8b7ec051a6d2264502c66f54eadf7 (patch)
tree2e5d6458fcfbec76104972ccc331e893bf947ef4 /pkgs
parent1b51366e6103ec3fca8931bcc4f9c89a585cda7d (diff)
python3Packages.ibis-framework: use version comparison for later removals
Diffstat (limited to 'pkgs')
-rw-r--r--pkgs/development/python-modules/ibis-framework/default.nix6
1 files changed, 2 insertions, 4 deletions
diff --git a/pkgs/development/python-modules/ibis-framework/default.nix b/pkgs/development/python-modules/ibis-framework/default.nix
index 7aebf690d2dd4..61b944b488369 100644
--- a/pkgs/development/python-modules/ibis-framework/default.nix
+++ b/pkgs/development/python-modules/ibis-framework/default.nix
@@ -80,8 +80,7 @@ buildPythonPackage rec {
     sqlalchemy
     tables
     toolz
-  ] ++ lib.optionals (pythonOlder "3.8") [
-    # TODO: remove when ibis 3.0.0 is released
+  ] ++ lib.optionals (pythonOlder "3.8" && lib.versionOlder version "3.0.0") [
     importlib-metadata
   ];
 
@@ -144,8 +143,7 @@ buildPythonPackage rec {
     done
 
     wait
-
-    # TODO: remove when 3.0.0 is released
+  '' + lib.optionalString (lib.versionOlder version "3.0.0") ''
     export PYTEST_BACKENDS="${backendsString}"
   '';