fix(Util.Socket): actually close the socket in gracefulClose

The close call was missing due to a previous oversight. While the socket
should have been closed by its finalizer, doing it explicitly is cleaner
and probably also means more predictable performance.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/Network/Gopher/Util/Socket.hs b/src/Network/Gopher/Util/Socket.hs
index 023aa1d..1a1eb9d 100644
--- a/src/Network/Gopher/Util/Socket.hs
+++ b/src/Network/Gopher/Util/Socket.hs
@@ -13,7 +13,7 @@ import Control.Monad (void, when)
 import Data.Functor ((<&>))
 import Foreign.C.Error (Errno (..), getErrno)
 import Foreign.C.Types (CInt (..))
-import System.Socket (receive, msgNoSignal, SocketException (..))
+import System.Socket (receive, msgNoSignal, SocketException (..), close, Family ())
 import System.Socket.Type.Stream (Stream ())
 import System.Socket.Protocol.TCP (TCP ())
 import System.Socket.Unsafe (Socket (..))
@@ -48,7 +48,7 @@ shutdown (Socket mvar) how = withMVar mvar $ \fd -> do
 --   of time to clean up on its end before closing
 --   the connection to avoid a broken pipe on the
 --   other side.
-gracefulClose :: Socket a Stream TCP -> IO ()
+gracefulClose :: Family f => Socket f Stream TCP -> IO ()
 gracefulClose sock = do
   -- send TCP FIN
   shutdown sock ShutdownWrite
@@ -57,4 +57,4 @@ gracefulClose sock = do
   -- something else which would mean protocol
   -- violation). Give up after 1s.
   _ <- race (void $ receive sock 16 msgNoSignal) (threadDelay 1000000)
-  pure ()
+  close sock